Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere_copy: Remove deprecated parameters #1456

Merged
merged 1 commit into from
Sep 9, 2022
Merged

vsphere_copy: Remove deprecated parameters #1456

merged 1 commit into from
Sep 9, 2022

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Fixes #1196

The parameters host and login are deprecated and should be removed in version 3.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vsphere_copy

ADDITIONAL INFORMATION

#1194

@softwarefactory-project-zuul
Copy link

Build failed.

❌ ansible-tox-linters FAILURE in 4m 09s
❌ build-ansible-collection FAILURE in 3m 15s
⚠️ ansible-test-sanity-docker-devel SKIPPED (non-voting)
⚠️ ansible-test-sanity-docker-milestone SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.12 SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.13 SKIPPED
⚠️ ansible-test-units-community-vmware-python38 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SKIPPED
⚠️ ansible-galaxy-importer SKIPPED

Warning:
Job ansible-tox-linters: unable to map line for file comments:
stderr: 'fatal: -L invalid line number: 0'

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

❌ ansible-tox-linters FAILURE in 4m 09s
❌ build-ansible-collection FAILURE in 3m 20s
⚠️ ansible-test-sanity-docker-devel SKIPPED (non-voting)
⚠️ ansible-test-sanity-docker-milestone SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.12 SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.13 SKIPPED
⚠️ ansible-test-units-community-vmware-python38 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SKIPPED
⚠️ ansible-galaxy-importer SKIPPED

Warning:
Job ansible-tox-linters: unable to map line for file comments:
stderr: 'fatal: -L invalid line number: 0'

@mariolenz mariolenz force-pushed the remove_deprecated-vsphere_copy-parameters branch from 10212fb to be8141e Compare September 8, 2022 15:33
@softwarefactory-project-zuul
Copy link

Build failed.

❌ ansible-tox-linters FAILURE in 4m 02s
❌ build-ansible-collection FAILURE in 4m 27s
⚠️ ansible-test-sanity-docker-devel SKIPPED (non-voting)
⚠️ ansible-test-sanity-docker-milestone SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.12 SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.13 SKIPPED
⚠️ ansible-test-units-community-vmware-python38 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SKIPPED
⚠️ ansible-galaxy-importer SKIPPED

Warning:
Job ansible-tox-linters: unable to map line for file comments:
stderr: 'fatal: -L invalid line number: 0'

@mariolenz mariolenz force-pushed the remove_deprecated-vsphere_copy-parameters branch from be8141e to 177f058 Compare September 8, 2022 15:46
@softwarefactory-project-zuul
Copy link

Build failed.

❌ ansible-tox-linters FAILURE in 4m 00s
❌ build-ansible-collection FAILURE in 3m 34s
⚠️ ansible-test-sanity-docker-devel SKIPPED (non-voting)
⚠️ ansible-test-sanity-docker-milestone SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.12 SKIPPED
⚠️ ansible-test-sanity-docker-stable-2.13 SKIPPED
⚠️ ansible-test-units-community-vmware-python38 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SKIPPED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SKIPPED
⚠️ ansible-galaxy-importer SKIPPED

Warning:
Job ansible-tox-linters: unable to map line for file comments:
stderr: 'fatal: -L invalid line number: 0'

@mariolenz mariolenz force-pushed the remove_deprecated-vsphere_copy-parameters branch from 177f058 to 5daf709 Compare September 8, 2022 15:54
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 40s
✔️ build-ansible-collection SUCCESS in 4m 07s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 50s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 38s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 20s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 30s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 51s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 44s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 19m 44s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 51m 44s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 43m 50s
✔️ ansible-galaxy-importer SUCCESS in 4m 13s

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 3m 25s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 09s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 00s
✔️ ansible-galaxy-importer SUCCESS in 4m 05s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4d1c5e0 into ansible-collections:main Sep 9, 2022
@mariolenz mariolenz deleted the remove_deprecated-vsphere_copy-parameters branch September 9, 2022 05:07
@mariolenz mariolenz mentioned this pull request Oct 9, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 9, 2022
@mariolenz
Update changelog fragments for a better porting guide (#1490)
438d066 
Update changelog fragments for a better porting guide

SUMMARY
Update changelog fragments for a better porting guide
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
vsphere_copy
vmware_dns_config
vmware_dvs_portgroup
vmware_guest_boot_manager
vmware_guest_network
vmware_guest_vnc
vmware_host_firewall_manager
ADDITIONAL INFORMATION
#1456
#1455
#1483
#1461
#1459
#1454
#1463
@renovate renovate bot mentioned this pull request Oct 10, 2022
Closed
1 task
@slauger slauger mentioned this pull request Oct 11, 2022
Closed
1 task
@slauger slauger mentioned this pull request Oct 24, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vsphere_copy: Remove deprecated parameters
1 participant
@mariolenz