Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_guest_boot_manager: Remove secure_boot_enabled default #1461

Merged

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Fixes #1257

When using this module to enable enter_bios_setup on a VM with UEFI and Secure Boot enabled, it will disable Secure Boot. I think the best way to fix this is to not have a default for secure_boot_enabled .

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest_boot_manager

ADDITIONAL INFORMATION

See #1257 for more information.

@mariolenz mariolenz added the WIP Work in progress label Sep 15, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 4m 46s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 40s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 27s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 27s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 22s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 48s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 20m 51s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 17m 15s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 54m 43s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 47m 36s
✔️ ansible-galaxy-importer SUCCESS in 5m 09s

Verified

This commit was signed with the committer’s verified signature.
webknjaz 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)
@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 4m 38s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 53s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 21s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 15s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 32s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 24s
ansible-test-cloud-integration-vcenter7_2esxi-stable212 RETRY_LIMIT in 6m 32s
ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 RETRY_LIMIT in 7m 00s
ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 FAILURE in 22m 38s
✔️ ansible-galaxy-importer SUCCESS in 3m 55s

@softwarefactory-project-zuul
Copy link

@mariolenz mariolenz force-pushed the issue1257 branch 7 times, most recently from 997a6bc to eed036b Compare September 16, 2022 17:45
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 4m 18s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 57s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 18s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 01s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 11s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 21s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 33s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 18m 04s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 53m 23s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 43m 34s
✔️ ansible-galaxy-importer SUCCESS in 4m 27s

@mariolenz mariolenz changed the title [WIP] vmware_guest_boot_manager: Remove secure_boot_enabled default vmware_guest_boot_manager: Remove secure_boot_enabled default Sep 17, 2022
@mariolenz mariolenz added mergeit and removed WIP Work in progress labels Sep 17, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 3m 26s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 55s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 59s
✔️ ansible-galaxy-importer SUCCESS in 4m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 52b308d into ansible-collections:main Sep 17, 2022
@mariolenz mariolenz deleted the issue1257 branch September 17, 2022 05:29
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 9, 2022
Update changelog fragments for a better porting guide

SUMMARY
Update changelog fragments for a better porting guide
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
vsphere_copy
vmware_dns_config
vmware_dvs_portgroup
vmware_guest_boot_manager
vmware_guest_network
vmware_guest_vnc
vmware_host_firewall_manager
ADDITIONAL INFORMATION
#1456
#1455
#1483
#1461
#1459
#1454
#1463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmware_guest_boot_manager changed default secure_boot_enabled value
1 participant