Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote route53 module_utils #1066

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

Promote route53 module_utils

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

badnetmask and others added 5 commits September 26, 2022 12:39
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3248016
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 36s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 30s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 05s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 08s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 28s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 40s
✔️ ansible-test-splitter SUCCESS in 2m 57s
integration-amazon.aws-1 FAILURE in 6m 15s
integration-amazon.aws-2 FAILURE in 6m 51s
integration-amazon.aws-3 FAILURE in 6m 36s
integration-amazon.aws-4 FAILURE in 6m 13s
integration-amazon.aws-5 FAILURE in 6m 08s
integration-amazon.aws-6 FAILURE in 6m 17s
integration-amazon.aws-7 FAILURE in 6m 52s
integration-amazon.aws-8 FAILURE in 6m 46s
integration-amazon.aws-9 FAILURE in 6m 05s
integration-amazon.aws-10 FAILURE in 6m 30s
integration-amazon.aws-11 FAILURE in 7m 34s
integration-amazon.aws-12 FAILURE in 7m 19s
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 17s

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module module_utils module_utils needs_triage new_plugin New plugin plugins plugin (any type) labels Sep 26, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added integration tests/integration tests tests labels Sep 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 44s
✔️ build-ansible-collection SUCCESS in 5m 12s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 26s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 16s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 13s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 02s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 01s
✔️ ansible-test-splitter SUCCESS in 2m 49s
integration-amazon.aws-1 FAILURE in 6m 27s
integration-amazon.aws-2 FAILURE in 6m 44s
integration-amazon.aws-3 FAILURE in 8m 13s
integration-amazon.aws-4 FAILURE in 7m 05s
integration-amazon.aws-5 FAILURE in 6m 56s
integration-amazon.aws-6 FAILURE in 6m 25s
integration-amazon.aws-7 FAILURE in 7m 55s
integration-amazon.aws-8 FAILURE in 7m 27s
integration-amazon.aws-9 FAILURE in 7m 17s
integration-amazon.aws-10 FAILURE in 8m 20s
integration-amazon.aws-11 FAILURE in 6m 28s
integration-amazon.aws-12 FAILURE in 8m 36s
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 33s

@tremble
Copy link
Contributor

tremble commented Sep 26, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 5m 53s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 37s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 49s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 51s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 44s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 46s
✔️ ansible-test-splitter SUCCESS in 2m 41s
✔️ integration-amazon.aws-1 SUCCESS in 31m 27s
✔️ integration-amazon.aws-2 SUCCESS in 17m 32s
✔️ integration-amazon.aws-3 SUCCESS in 25m 20s
✔️ integration-amazon.aws-4 SUCCESS in 12m 03s
✔️ integration-amazon.aws-5 SUCCESS in 11m 05s
✔️ integration-amazon.aws-6 SUCCESS in 25m 16s
integration-amazon.aws-7 FAILURE in 37m 36s
integration-amazon.aws-8 FAILURE in 6m 24s
✔️ integration-amazon.aws-9 SUCCESS in 46m 28s
✔️ integration-amazon.aws-10 SUCCESS in 1h 00m 21s
integration-amazon.aws-11 TIMED_OUT in 1h 00m 41s
✔️ integration-amazon.aws-12 SUCCESS in 44m 39s
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 15s

@goneri
Copy link
Member

goneri commented Sep 26, 2022

recheck

@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label Sep 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 01s
✔️ build-ansible-collection SUCCESS in 3m 06s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 41s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8183000 into ansible-collections:main Sep 26, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 27, 2022
Add route53 sanity ignore entry for 2.15 (devel)

Depends-On: #1066
SUMMARY
SSIA
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/sanity
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 27, 2022
doc: Fix readme typo and misc

Depends-On: #1066
SUMMARY


Fix pip install command typo and formal name of FQCN.
ISSUE TYPE


Docs Pull Request

COMPONENT NAME


README.md

ADDITIONAL INFORMATION



n/a

Reviewed-by: Mark Chappell <None>
patchback bot pushed a commit that referenced this pull request Sep 27, 2022
doc: Fix readme typo and misc

Depends-On: #1066
SUMMARY

Fix pip install command typo and formal name of FQCN.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

README.md

ADDITIONAL INFORMATION

n/a

Reviewed-by: Mark Chappell <None>
(cherry picked from commit 9705493)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 27, 2022
[PR #1065/9705493a backport][stable-4] doc: Fix readme typo and misc

This is a backport of PR #1065 as merged into main (9705493).
Depends-On: #1066
SUMMARY


Fix pip install command typo and formal name of FQCN.
ISSUE TYPE


Docs Pull Request

COMPONENT NAME


README.md

ADDITIONAL INFORMATION



n/a

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 27, 2022
new module: cloudwatch_metric_alarm_info

SUMMARY
Depends-On: #1066
Should be merged only after #1028 is merged.

Adding a new module for retrieving cloudwatch metric alarms info.

Currently supports following boto API(s)
describe_alarms()
ISSUE TYPE


New Module Pull Request

COMPONENT NAME

cloudwatch_metric_alarm_info
ADDITIONAL INFORMATION


Will be useful in moving these tasks from aws cli commands to amazon.aws module.
https://github.com/ansible-collections/community.aws/blob/main/tests/integration/targets/cloudwatch_metric_alarm/tasks/main.yml#L63-L70
ansible-collections/community.aws#1440
The integration tests for this info module will be added to above tests, after the cloudwatch_metric_alarm module is migrated from community.aws to amazon.aws.

Sample playbook
---
- name: Create a metric alarm & get info
  hosts: localhost
  gather_facts: false
  tasks:
    - name: create alarm
      community.aws.cloudwatch_metric_alarm:
        state: present
        region: us-east-2
        name: "cpu-low-test-metric-alarm-1234"
        metric: "CPUUtilization"
        namespace: "AWS/EC2"
        statistic: Average
        comparison: "LessThanOrEqualToThreshold"
        threshold: 50.0
        period: 180
        evaluation_periods: 3
        unit: "Percent"
        description: "This will alarm when a instance's CPU usage average is lower than 50%"
        dimensions: {'InstanceId':'i-00a8b34xxxxxxxxxx'}

    - name: describe the metric alarm based on metric name and namespace
      amazon.aws.cloudwatch_metric_alarm_info:
        alarm_names:
          - cpu-low-test-metric-alarm-1234
      register: alarm_info

    - debug:
        var: alarm_info

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 29, 2022
inventory/aws_ec2: allow multi-entries for one host

Depends-On: #1066
Add an option to allow multiple duplicated entries for one single instance.
Closes: #950

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 12, 2022
ec2_ami: Add support for params BootMode, TpmSupport, UefiData

SUMMARY
Depends-On: #1066

Added support for params BootMode, TpmSupport, UefiData in ec2_ami.

Fixes #944
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_ami
ADDITIONAL INFORMATION



Example playbook
- name: abc
  hosts: localhost
  gather_facts: false
  tasks:
    - name: AMI Creation with boot_mode and tpm_support
      amazon.aws.ec2_ami:
        name: ami-create-test_legacy-bios
        state: present
        architecture: x86_64
        virtualization_type: hvm
        root_device_name: /dev/sda1
        device_mapping:
          - device_name: /dev/sda1
            snapshot_id: snap-xxxxxxxxx
        wait: yes
        region: us-east-2
        boot_mode: legacy-bios
        tpm_support: v2.0
        tags:
          name: ami-create-test

Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Mike Graves <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Apr 27, 2023
…le-collections#1037)

ec2_ami: Add support for params BootMode, TpmSupport, UefiData

SUMMARY
Depends-On: ansible-collections#1066

Added support for params BootMode, TpmSupport, UefiData in ec2_ami.

Fixes ansible-collections#944
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_ami
ADDITIONAL INFORMATION



Example playbook
- name: abc
  hosts: localhost
  gather_facts: false
  tasks:
    - name: AMI Creation with boot_mode and tpm_support
      amazon.aws.ec2_ami:
        name: ami-create-test_legacy-bios
        state: present
        architecture: x86_64
        virtualization_type: hvm
        root_device_name: /dev/sda1
        device_mapping:
          - device_name: /dev/sda1
            snapshot_id: snap-xxxxxxxxx
        wait: yes
        region: us-east-2
        boot_mode: legacy-bios
        tpm_support: v2.0
        tags:
          name: ami-create-test

Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Mike Graves <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 28, 2023
#1487)

[manual backport stable-5] ec2_ami: Add support for params BootMode, TpmSupport, UefiData (#1037)

ec2_ami: Add support for params BootMode, TpmSupport, UefiData
SUMMARY
Depends-On: #1066
Added support for params BootMode, TpmSupport, UefiData in ec2_ami.
Fixes #944
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ec2_ami
ADDITIONAL INFORMATION
Example playbook

name: abc hosts: localhost gather_facts: false tasks: - name: AMI Creation with boot_mode and tpm_support amazon.aws.ec2_ami: name: ami-create-test_legacy-bios state: present architecture: x86_64 virtualization_type: hvm root_device_name: /dev/sda1 device_mapping: - device_name: /dev/sda1 snapshot_id: snap-xxxxxxxxx wait: yes region: us-east-2 boot_mode: legacy-bios tpm_support: v2.0 tags: name: ami-create-test

Reviewed-by: Gonéri Le Bouder [email protected]
Reviewed-by: Mandar Kulkarni [email protected]
Reviewed-by: Mike Graves [email protected]
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants