Migrate cloudwatch_metric_alarm* modules and tests #1028
Conversation
alinabuzachis
changed the title
|
@alinabuzachis: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
integration
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
force-pushed
the
promote_cloudwatch_metric_alarm
branch
5 times, most recently
from
d7f3917 to
b68f617
Compare
tests/integration/targets/cloudwatch_metric_alarm/vars/main.yml
Outdated
Show resolved
Hide resolved
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
goneri
force-pushed
the
promote_cloudwatch_metric_alarm
branch
from
570c8f0 to
0d432fe
Compare
|
regate |
ansibullbot
removed
needs_rebase
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 20s |
|
Pull request merge failed: Pull Request is not mergeable |
goneri
force-pushed
the
promote_cloudwatch_metric_alarm
branch
from
0d432fe to
ddf9b54
Compare
|
regate |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
ansibullbot
added
needs_rebase
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
regate |
Rename cloudwatch metrics_alarm SUMMARY In line with the new naming guidelines rename ec2_metric_alarm to cloudwatch_metric_alarm ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/cloudwatch_metric_alarm.py plugins/modules/ec2_metric_alarm.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@88c62c5
goneri
force-pushed
the
promote_cloudwatch_metric_alarm
branch
from
08916be to
3b9860b
Compare
|
regate |
ansibullbot
removed
needs_rebase
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 45s |
new module: cloudwatch_metric_alarm_info SUMMARY Depends-On: #1066 Should be merged only after #1028 is merged. Adding a new module for retrieving cloudwatch metric alarms info. Currently supports following boto API(s) describe_alarms() ISSUE TYPE New Module Pull Request COMPONENT NAME cloudwatch_metric_alarm_info ADDITIONAL INFORMATION Will be useful in moving these tasks from aws cli commands to amazon.aws module. https://github.com/ansible-collections/community.aws/blob/main/tests/integration/targets/cloudwatch_metric_alarm/tasks/main.yml#L63-L70 ansible-collections/community.aws#1440 The integration tests for this info module will be added to above tests, after the cloudwatch_metric_alarm module is migrated from community.aws to amazon.aws. Sample playbook --- - name: Create a metric alarm & get info hosts: localhost gather_facts: false tasks: - name: create alarm community.aws.cloudwatch_metric_alarm: state: present region: us-east-2 name: "cpu-low-test-metric-alarm-1234" metric: "CPUUtilization" namespace: "AWS/EC2" statistic: Average comparison: "LessThanOrEqualToThreshold" threshold: 50.0 period: 180 evaluation_periods: 3 unit: "Percent" description: "This will alarm when a instance's CPU usage average is lower than 50%" dimensions: {'InstanceId':'i-00a8b34xxxxxxxxxx'} - name: describe the metric alarm based on metric name and namespace amazon.aws.cloudwatch_metric_alarm_info: alarm_names: - cpu-low-test-metric-alarm-1234 register: alarm_info - debug: var: alarm_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Gonéri Le Bouder <[email protected]>
Copy ignore-2.13.txt to ignore-2.14.txt SUMMARY Relates to ansible-collections/news-for-maintainers#13 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]>
Depends-On: ansible/zuul-config#443
Migrate cloudwatch_metric_alarm* modules and tests