[DNM] test replace aws cli calls with cloudwatch_metric_alarm_info tasks #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Sep 27, 2022
new module: cloudwatch_metric_alarm_info SUMMARY Depends-On: #1066 Should be merged only after #1028 is merged. Adding a new module for retrieving cloudwatch metric alarms info. Currently supports following boto API(s) describe_alarms() ISSUE TYPE New Module Pull Request COMPONENT NAME cloudwatch_metric_alarm_info ADDITIONAL INFORMATION Will be useful in moving these tasks from aws cli commands to amazon.aws module. https://github.com/ansible-collections/community.aws/blob/main/tests/integration/targets/cloudwatch_metric_alarm/tasks/main.yml#L63-L70 ansible-collections/community.aws#1440 The integration tests for this info module will be added to above tests, after the cloudwatch_metric_alarm module is migrated from community.aws to amazon.aws. Sample playbook --- - name: Create a metric alarm & get info hosts: localhost gather_facts: false tasks: - name: create alarm community.aws.cloudwatch_metric_alarm: state: present region: us-east-2 name: "cpu-low-test-metric-alarm-1234" metric: "CPUUtilization" namespace: "AWS/EC2" statistic: Average comparison: "LessThanOrEqualToThreshold" threshold: 50.0 period: 180 evaluation_periods: 3 unit: "Percent" description: "This will alarm when a instance's CPU usage average is lower than 50%" dimensions: {'InstanceId':'i-00a8b34xxxxxxxxxx'} - name: describe the metric alarm based on metric name and namespace amazon.aws.cloudwatch_metric_alarm_info: alarm_names: - cpu-low-test-metric-alarm-1234 register: alarm_info - debug: var: alarm_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Gonéri Le Bouder <[email protected]>
|
closed as ansible-collections/amazon.aws#988 is merged. |
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#1440) Don't consider prop 'StateTransitionedTimestamp' in change detection SUMMARY Remove property 'StateTransitionedTimestamp' from the list of props when determining if an alarm has changed and needs to be create/updated. Fixes ansible-collections#1439 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudwatch-metric-alarm ADDITIONAL INFORMATION See issue ansible-collections#1439 for additional details. Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Depends-On: ansible-collections/amazon.aws#988
Testing
cloudwatch_metric_alarm_infomodule to use incloud_metric_alarmintegration tests.ISSUE TYPE
COMPONENT NAME
cloudwatch_metric_alarm
ADDITIONAL INFORMATION