Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Control API support #765

Closed
wants to merge 1 commit into from
Closed

Add Cloud Control API support #765

wants to merge 1 commit into from

Conversation

meeuw
Copy link

@meeuw meeuw commented Mar 31, 2022

SUMMARY

Add Cloud Control API support

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Cloud Control API is an Uniform API to Access AWS & Third-Party Services.

This will give (what it seems) the same possibilities as CloudFormation to Ansible ❗

I'm actually pretty amazed how simple but powerful this module already is!

ADDITIONAL INFORMATION

This is still WIP, if you can please help me finish it by giving me some pointers. How can I run the test suite? I've tried running pytest in a Python 3.10 and 3.7 venv (various errors), tried running ansible-test (other errors).

https://github.com/ansible-collections/amazon.aws/blob/main/CONTRIBUTING.md isn't very helpful.

What documentation is required?

Does it make sense to add this module to this git repository? Please point me in the right direction if it isn't.

How do you think of the name of the module, would cloud_control (without _api) be better?

Please extend the below TODO list if I'm missing something.

TODO:
  • Add tests
  • Add documentation
  • Agree about name of module
  • Make waiter configurable
  • Add module dependencies to project (jsonpatch)
EXAMPLE PLAYBOOK
- name: aws cloud control
  hosts: all
  tasks:
    - name: aws cloud control
      cloud_control_api:
        type_name: AWS::IAM::Role
        identifier: DmtestRole2
        properties:
          AssumeRolePolicyDocument:
            Statement:
            - Action: sts:AssumeRole
              Condition:
                Bool:
                  aws:MultiFactorAuthPresent: 'true'
              Effect: Allow
              Principal:
                AWS: arn:aws:iam::000000000000:root
            Version: '2012-10-17'
          ManagedPolicyArns:
          - arn:aws:iam::aws:policy/AdministratorAccess
          MaxSessionDuration: 3600
          Path: /
          RoleName: DmtestRole2
    - name: aws cloud control delete detach policies
      cloud_control_api:
        type_name: AWS::IAM::Role
        identifier: DmtestRole2
        state: absent
        properties:
          ManagedPolicyArns:
          - arn:aws:iam::aws:policy/AdministratorAccess
    - name: aws cloud control delete
      cloud_control_api:
        type_name: AWS::IAM::Role
        identifier: DmtestRole2
        state: absent

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor new_module New module new_plugin New plugin plugins plugin (any type) python3 labels Mar 31, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jillr
Copy link
Collaborator

jillr commented Apr 1, 2022

Hi @meeuw, thanks very much for your interest in extending the amazon.aws collection! This collection is maintained by the Red Hat Ansible team and contains modules that are officially supported by Red Hat. The Ansible community accepts PRs for new modules to the https://github.com/ansible-collections/community.aws collection. Could you please open a PR for this change in that repo?
https://docs.ansible.com/ansible/devel/community/contributing_maintained_collections.html

You can find more information about our development guidelines and how to get started with AWS modules, including information about module classes and module utilities used in both of these collections, in these links:
https://docs.ansible.com/ansible/devel/dev_guide/platforms/aws_guidelines.html
https://www.ansible.com/blog/getting-started-with-aws-ansible-module-development

@jillr jillr closed this Apr 1, 2022
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3248016
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3248016
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3248016
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3248016
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 26, 2022
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3248016
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 26, 2022
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3248016
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
route53_health_check - add tagging support

SUMMARY
add tagging support to route53_health_check
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor new_module New module new_plugin New plugin plugins plugin (any type) python3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants