-
Notifications
You must be signed in to change notification settings - Fork 3.4k
tabs: wrong tab position when a new tab is added #11689
Comments
Thank you for this report! We'll work on a fix for this ASAP! |
This is caused by this line in material/src/components/tabs/tabs.scss Line 169 in 2b2f441
and this block in material/src/components/tabs/js/tabsController.js Lines 575 to 580 in a49043d
|
These are both (PR #11432 and PR #11567) a result of the need to fix this regression in IE with pagination. We had better fixes that didn't use |
fix for browsers other than IE Fixes #11689
OK, f2dbe07 will fix this for browsers other than IE11. IE11 still needs this
|
<!-- Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed. --> ## PR Checklist Please check that your PR fulfills the following requirements: - [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format) - [ ] Tests for the changes have been added or this is not a bug fix / enhancement - [x] Docs have been added, updated, or were not required ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Enhancement [ ] Documentation content changes [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Infrastructure changes [ ] Other... Please describe: ``` ## What is the current behavior? The scroll to new tab animation is broken. <!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. --> Issue Number: Fixes #11689 ## What is the new behavior? The scroll to new tab animation is fixed for browsers other than IE. ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ``` <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. --> ## Other information
Bug, enhancement request, or proposal:
There is an error with tabs position when you add a new tab and it does not fit and needs to be horizontally scrolled.
CodePen and steps to reproduce the issue:
CodePen Demo which demonstrates the issue:
Detailed Reproduction Steps:
What is the expected behavior?
A new tab is created and tabs are scrolled to it. Then you can go back with the left arrow until first tab.
What is the current behavior?
A new tab is created and tabs are scrolled to it. You cannot see any tab until you click on left arrow, then you see some tabs and you cannot go to previous tabs.
What is the use-case or motivation for changing an existing behavior?
I want to create new tabs dynamically and I want to be able to go to first tab.
Which versions of AngularJS, Material, OS, and browsers are affected?
Is there anything else we should know? Stack Traces, Screenshots, etc.
This bug occurs since AngularJS Material v1.1.11, with v1.1.10 it is working correctly.
The text was updated successfully, but these errors were encountered: