Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(tabs): md-center-tabs causes tabs to not render #11567

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

md-center-tabs is broken and doesn't render without clicking on the tab bar. Even then it renders partially off screen on Firefox and in some other cases.

Note that only one of center tabs or pagination can be activate at a time.

Issue Number:
Fixes #11566. Relates to #11432.

What is the new behavior?

Only apply the width = 999999px work around when pagination is enabled.
md-center-tabs works properly on Firefox, IE11, Edge, Safari, and Chrome.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This preserves the fix to the regression in v1.1.2 where IE11 doesn't show the tab labels when pagination is enabled. While at the same time fixing the regression in v1.1.11 with md-center-tabs.

only apply the width = 999999px work around when pagination is enabled
only one of center tabs or pagination can be activate at a time

Fixes #11566. Relates to #11432.
@Splaktar Splaktar self-assigned this Dec 27, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 27, 2018
@Splaktar Splaktar added this to the 1.1.12 milestone Dec 27, 2018
@Splaktar Splaktar added type: bug severity: regression This issue is related to a regression P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review labels Dec 27, 2018
@mmalerba mmalerba merged commit a49043d into master Jan 3, 2019
@Splaktar Splaktar deleted the tabs-centerTabsRegression branch January 3, 2019 00:33
@Splaktar Splaktar assigned mmalerba and unassigned josephperrott Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tabs: with "md-center-tabs" has layout issues
4 participants