Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-tabs: text turns to dots on small screen on IE11 #10406

Closed
jarekskuder opened this issue Feb 15, 2017 · 21 comments · Fixed by #11432
Closed

md-tabs: text turns to dots on small screen on IE11 #10406

jarekskuder opened this issue Feb 15, 2017 · 21 comments · Fixed by #11432
Assignees
Labels
browser: IE This issue is specific to Internet Explorer has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. resolution: fixed severity: regression This issue is related to a regression type: bug
Milestone

Comments

@jarekskuder
Copy link

jarekskuder commented Feb 15, 2017

I need tabs to be streched always and on small screans to, but words are turning in to dots or half of a word turns to dots. I thought maybe words are too big, but then i tried to resize the window and then it turns to normal words.

My code:

<md-tabs class="main-tabs" md-selected="vm.selectedIndex"
             md-center-tabs md-border-bottom md-autoselect md-no-ink
             md-no-pagination="false"
             md-stretch-tabs="auto"
             style="width: auto !important; margin-top: 10px;">
        <md-tab ng-click="openLeftMenu()" id="tab1">
            <md-tab-label>{{translates.top_menu_meniu}}</md-tab-label>
        </md-tab>
        <md-tab ui-sref="map" id="tab2">
            <md-tab-label>{{translates.top_menu_map}}</md-tab-label>
        </md-tab>
        <md-tab ui-sref="list" id="tab3">
            <md-tab-label>{{translates.top_menu_list}}</md-tab-label>
        </md-tab>
    </md-tabs>
@EladBezalel
Copy link
Member

Please provide a codepen so we can investigate further.

@EladBezalel EladBezalel added needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue P5: nice to have These issues will not be fixed without community contributions. labels Mar 18, 2017
@gbruins
Copy link

gbruins commented May 25, 2017

This also happens in IE11. Open the demo page in IE 11 to see the issue:
https://material.angularjs.org/latest/demo/tabs

@gbruins
Copy link

gbruins commented Jun 5, 2017

May I suggest that the 'needs:demo' and 'P5 - Needs Investigation' labels be removed? This issue is 'demoable' on this page when viewing in IE11: https://material.angularjs.org/latest/demo/tabs

Perhaps the "browser: IE" label can be added as well to give this issue more visibility and urgency.

@EladBezalel EladBezalel added browser: IE This issue is specific to Internet Explorer P4: minor Minor issues. May not be fixed without community contributions. and removed needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue P5: nice to have These issues will not be fixed without community contributions. labels Jun 6, 2017
@gbruins
Copy link

gbruins commented Jun 9, 2017

This bug was introduced in 1.1.2

@waegen
Copy link

waegen commented Jun 21, 2017

+1 for a fix - We are too running into this issue when number of tabs exceeds the horizontal space

1 similar comment
@peter-imrich
Copy link

+1 for a fix - We are too running into this issue when number of tabs exceeds the horizontal space

@LoganDupont
Copy link

+1

2 similar comments
@indexofmetals
Copy link

+1

@amritk
Copy link

amritk commented Dec 23, 2017

+1

@motabass
Copy link

+1

@Splaktar Splaktar added severity: regression This issue is related to a regression P2: required Issues that must be fixed. type: bug and removed P4: minor Minor issues. May not be fixed without community contributions. labels Feb 11, 2018
@Splaktar Splaktar added this to the 1.1.8 milestone Feb 11, 2018
@Splaktar Splaktar added needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community needs: Pull Request labels Feb 11, 2018
@Splaktar Splaktar changed the title md-tabs text turn to dots in small screan md-tabs text turn to dots in small screen on IE11 Feb 11, 2018
@Splaktar
Copy link
Member

Verified that this is not reproducible on Chrome, Firefox, or Safari.

@Splaktar Splaktar changed the title md-tabs text turn to dots in small screen on IE11 md-tabs: text turns to dots on small screen on IE11 Feb 11, 2018
@Splaktar Splaktar modified the milestones: 1.1.8, 1.1.9 Mar 16, 2018
@Nickproger
Copy link
Contributor

image

We've got the same issue :(

@Splaktar
Copy link
Member

As mentioned by @zakaoai, just setting the md-pagination-wrapper's width is not enough. If you only change that, then the inkbars and paging buttons can get very out of sync and broken.

I tried just adding flex: auto but that didn't help at all. I'm going to explore some other flexbox compatible options. I really don't want to revert back to manual width calculations since that caused issues with tabs and more.

Splaktar added a commit that referenced this issue Aug 30, 2018
tab-items should have 12px right/left padding instead of 24px
- this is to align with the spec and more of the label visible on mobile
previous commits removed use of getMinTabWidth but never updated CSS
- this applies the proper min-width CSS to match the spec
remove unused calcPagingWidth()
convert all translate3d to translate for better IE11 support

Fixes #10406
@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue and removed for: external contributor needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Aug 30, 2018
@Splaktar
Copy link
Member

I have opened PR #11432 to address this via CSS changes to md-tab and md-tab-item.

Splaktar added a commit that referenced this issue Sep 10, 2018
tab-items should have 12px right/left padding instead of 24px
- this is to align with the spec and more of the label visible on mobile
previous commits removed use of getMinTabWidth but never updated CSS
- this applies the proper min-width CSS to match the spec
remove unused calcPagingWidth()
convert all translate3d to translate for better IE11 support

Fixes #10406
Splaktar added a commit that referenced this issue Sep 10, 2018
tab-items should have 12px right/left padding instead of 24px
- this is to align with the spec and more of the label visible on mobile
remove unused calcPagingWidth()
convert all translate3d to translate for better IE11 support

Fixes #10406
Splaktar added a commit that referenced this issue Sep 10, 2018
previous commits removed use of getMinTabWidth but never updated CSS
- this applies the proper min-width CSS to match the spec
- which is 72px on xs and 160px on everything else

Relates to #10406. Relates to #11432.
Splaktar added a commit that referenced this issue Sep 25, 2018
remove unused calcPagingWidth()
convert all translate3d to translate for better IE11 support

Fixes #10406
Splaktar added a commit that referenced this issue Oct 2, 2018
remove unused calcPagingWidth()
convert all translate3d to translate for better IE11 support

Fixes #10406
andrewseguin pushed a commit that referenced this issue Nov 15, 2018
…#11432)

remove unused calcPagingWidth()
convert all translate3d to translate for better IE11 support

Fixes #10406
Splaktar added a commit that referenced this issue Jun 29, 2020
- tab-items should have `12px` right/left padding instead of `24px`
  - this is to align with the spec and more of the label visible on mobile
- remove unused `calcPagingWidth()`
- convert all `translate3d` to `translate` for better IE11 support

Fixes #10406.

BREAKING CHANGE: Tab items now have a `min-width` and `padding` which matches the Material Design specification. For width, this is `72px` on `xs` screens and `160px` on all other screens. For left and right `padding`, this is now `12px` instead of `24px`. If your app needs to have tabs which are smaller than the spec, you will need to override `md-tab-item`'s `min-width` and `md-tab`'s `padding` styles.
Splaktar added a commit that referenced this issue Jun 29, 2020
previous commits removed use of getMinTabWidth but never updated CSS
- this applies the proper min-width CSS to match the spec
- which is 72px on xs and 160px on everything else

Relates to #10406. Relates to #11432.
Splaktar added a commit that referenced this issue Jun 29, 2020
- previous commits removed use of `getMinTabWidth` but never updated the related CSS
  - this applies the proper `min-width` CSS to match the spec
  - which is `72px` on `xs` and `160px` on everything else
- this also changes the left and right padding from `24px` to `12px` to align with the spec

Relates to #10406. Relates to #11432.

BREAKING CHANGE: Tab items now have a `min-width` and `padding` which matches the Material Design specification. For width, this is `72px` on `xs` screens and `160px` on all other screens. For left and right `padding`, this is now `12px` instead of `24px`. If your app needs to have tabs which are smaller than the spec, you will need to override `md-tab-item`'s `min-width` and `md-tab`'s `padding` styles.
Splaktar added a commit that referenced this issue Jun 30, 2020
- previous commits removed use of `getMinTabWidth` but never updated the related CSS
  - this applies the proper `min-width` CSS to match the spec
  - which is `72px` on `xs` and `160px` on everything else
- this also changes the left and right padding from `24px` to `12px` to align with the spec

Relates to #10406. Relates to #11432.

BREAKING CHANGE: Tab items now have a `min-width` and `padding` which matches the Material Design specification. For width, this is `72px` on `xs` screens and `160px` on all other screens. For left and right `padding`, this is now `12px` instead of `24px`. If your app needs to have tabs which are smaller than the spec, you will need to override `md-tab-item`'s `min-width` and `md-tab`'s `padding` styles.
@thesunfern
Copy link

Try setting the CSS property for it. .md-tabs{ overflow : visible; }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: IE This issue is specific to Internet Explorer has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. resolution: fixed severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.