This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): update min-width to follow the spec #11438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
added
type: bug
severity: regression
googlebot
added
the
cla: yes
3 tasks
Splaktar
force-pushed
the
changeTabMinWidth
branch
from
b7e1414
to
4ce6f0c
Compare
|
Rebased and added breaking change note to commit message. |
- previous commits removed use of `getMinTabWidth` but never updated the related CSS - this applies the proper `min-width` CSS to match the spec - which is `72px` on `xs` and `160px` on everything else - this also changes the left and right padding from `24px` to `12px` to align with the spec Relates to #10406. Relates to #11432. BREAKING CHANGE: Tab items now have a `min-width` and `padding` which matches the Material Design specification. For width, this is `72px` on `xs` screens and `160px` on all other screens. For left and right `padding`, this is now `12px` instead of `24px`. If your app needs to have tabs which are smaller than the spec, you will need to override `md-tab-item`'s `min-width` and `md-tab`'s `padding` styles.
Splaktar
force-pushed
the
changeTabMinWidth
branch
from
4ce6f0c
to
bcf4fb4
Compare
andrewseguin
approved these changes
Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previous commits removed use of
getMinTabWidth()but never updated the CSS to apply the propermin-width.72pxeven though they should have a min width of160px"on larger devices" according to the MD spec.Issue Number:
Relates to #10406. Relates to #11432.
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This is not a breaking API or CSS change, but it will break screenshot tests. However the new result is aligned with the Material Design spec.
Also please note that this is fixing a regression from a breaking change that was in 1.1.2.
Before (IE on bottom, Chrome on top):
After in IE (Chrome and IE look the same now)
And here is IE11 rendering with a small width (sub
600px)