Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(tabs): new tab animation broken by code to support IE11 #11711

Merged
merged 1 commit into from
Apr 23, 2019
Merged

fix(tabs): new tab animation broken by code to support IE11 #11711

merged 1 commit into from
Apr 23, 2019

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The scroll to new tab animation is broken.

Issue Number:
Fixes #11689

What is the new behavior?

The scroll to new tab animation is fixed for browsers other than IE.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 19, 2019
@Splaktar Splaktar self-assigned this Apr 19, 2019
@Splaktar Splaktar added this to the 1.1.19 milestone Apr 19, 2019
@Splaktar Splaktar added P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression g3: sync type: bug labels Apr 19, 2019
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Apr 19, 2019
Splaktar
Splaktar commented Apr 19, 2019
View reviewed changes
src/core/util/util.js
* documentMode is an IE-only property
* http://msdn.microsoft.com/en-us/library/ie/cc196988(v=vs.85).aspx
*/
msie: window.document.documentMode
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from AngularJS

Splaktar
Splaktar commented Apr 19, 2019
View reviewed changes
src/components/tabs/js/tabsController.js
// Don't do this on other browsers because it breaks scroll to new tab animation.
if ($mdUtil.msie) {
if (shouldPaginate) {
getElements().paging.style.width = '999999px';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping this in a check for IE is the actual fix for non-IE browsers.

@mmalerba mmalerba merged commit 1063a92 into master Apr 23, 2019
@Splaktar Splaktar deleted the tabs-fixDynamicTabsRegression branch April 24, 2019 19:43
@gauravlodha
Copy link

gauravlodha commented May 11, 2019 •
edited
Loading

@Splaktar: after this commit, tabs getting added twice the time in mobile devices works fine for desktop,
the issue exists on the demo itself

@Splaktar Splaktar mentioned this pull request May 18, 2019
Closed
@Splaktar
Copy link
Member Author

@gauravlodha I opened #11725 to track that issue. Thank you for reporting.

@Splaktar
Copy link
Member Author

Splaktar commented May 23, 2019 •
edited
Loading

The check is working on Microsoft Edge 44.17763.1.0 and the md-pagination-wrapper's width isn't being tweaked, but the new tab animation is still broken in the same way that IE11 is.

MS Edge Chromium is working fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Splaktar Splaktar

@mmalerba mmalerba

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Milestone
1.1.19
Development

Successfully merging this pull request may close these issues.

tabs: wrong tab position when a new tab is added
4 participants
@Splaktar @gauravlodha @googlebot @mmalerba