Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of for-of #2

Closed
cramforce opened this issue Sep 3, 2015 · 3 comments
Closed

Remove usages of for-of #2

cramforce opened this issue Sep 3, 2015 · 3 comments
Assignees
@erwinmombay

Comments

@cramforce
Copy link
Member

Each one generates 2 try-catch-finally blocks.

Disgusting :)
@erwinmombay
Copy link
Member

@cramforce mind if i take this? i should be able to work on it on the weekend.

@cramforce
Copy link
Member Author

Go for it!

@erwinmombay
Copy link
Member

landed in 9ceee31. feel free to close

cramforce pushed a commit that referenced this issue Sep 11, 2015
@rgthree
Merge pull request #2 from rgthree/audio
9d1826c 
Move audio to /extensions
This was referenced Oct 28, 2015
Closed
Merged
mrsufgi referenced this issue in apester-dev/amphtml Aug 28, 2016
validator fix #2
d97e4dc
dvoytenko pushed a commit that referenced this issue Sep 6, 2016
@mrsufgi @dvoytenko
<amp-apester-media> add apester-media tag to AMP (#4291)
8b81b36 
* Initial implementation of <amp-apester-media>
- no playlist support yet
- public stage3-renderer doesn't send 'embed-size' with amp sentinel yet.

* lint
getWin() removed

* remove width from test

* Initial implementation of <amp-apester-media>
- no playlist support yet
- public stage3-renderer doesn't send 'embed-size' with amp sentinel yet.

* lint
getWin() removed

* remove width from test

* isLayoutSupported uncommented, support only fixed height

* pr comments fixes
- lint

* fix ident

* fix imports

* removed loader from PR

* -added random playlist support
-add preconnect to display service
-querying media on layoutCallback

* - sending 'seen' events

* added html_format: AMP @powdercloud

* minor fixes, added mocha tests.

* updated encoding/decoding
removed apester css prefixes
removed height attribute changes -> now changeHeight handle this.
note: I had to put setTimeout on height check cause it seems like this test happens before the attemptChangeHeight actually change this value.

* new line in test-amp-apester-media

* validator fix

* validator fix #2

* removed decodeUrl

* css in code changes

* validator fix: data-apester-media to data-apester-media-id
dreamofabear pushed a commit to dreamofabear/amphtml that referenced this issue Sep 16, 2016
@mrsufgi
<amp-apester-media> add apester-media tag to AMP (ampproject#4291)
28373ab 
* Initial implementation of <amp-apester-media>
- no playlist support yet
- public stage3-renderer doesn't send 'embed-size' with amp sentinel yet.

* lint
getWin() removed

* remove width from test

* Initial implementation of <amp-apester-media>
- no playlist support yet
- public stage3-renderer doesn't send 'embed-size' with amp sentinel yet.

* lint
getWin() removed

* remove width from test

* isLayoutSupported uncommented, support only fixed height

* pr comments fixes
- lint

* fix ident

* fix imports

* removed loader from PR

* -added random playlist support
-add preconnect to display service
-querying media on layoutCallback

* - sending 'seen' events

* added html_format: AMP @powdercloud

* minor fixes, added mocha tests.

* updated encoding/decoding
removed apester css prefixes
removed height attribute changes -> now changeHeight handle this.
note: I had to put setTimeout on height check cause it seems like this test happens before the attemptChangeHeight actually change this value.

* new line in test-amp-apester-media

* validator fix

* validator fix ampproject#2

* removed decodeUrl

* css in code changes

* validator fix: data-apester-media to data-apester-media-id
mrsufgi referenced this issue in apester-dev/amphtml Nov 2, 2016
@zhouyx
create 1.0 version for amp-sticky-ad extension (ampproject#5923)
76de034 
* add 1.0 folder

* add test

* test fixed by Dima

* fix tests

* fix share-tracking test

added html_format: AMP @powdercloud

new line in test-amp-apester-media

validator fix #2

removed decodeUrl

validator fix: data-apester-media to data-apester-media-id

minor changes to css and loader

refactor(css): change css classes

css
mrsufgi referenced this issue in apester-dev/amphtml Nov 2, 2016
@zhouyx
create 1.0 version for amp-sticky-ad extension (ampproject#5923)
91e54d0 
* add 1.0 folder

* add test

* test fixed by Dima

* fix tests

* fix share-tracking test

added html_format: AMP @powdercloud

new line in test-amp-apester-media

validator fix #2

removed decodeUrl

validator fix: data-apester-media to data-apester-media-id

minor changes to css and loader

refactor(css): change css classes

css

added html_format: AMP @powdercloud

new line in test-amp-apester-media

validator fix #2

removed decodeUrl

validator fix: data-apester-media to data-apester-media-id

refactor(css): change css classes

css
mityaha pushed a commit to ooyala/amphtml that referenced this issue Nov 30, 2016
@mrsufgi @mityaha
<amp-apester-media> add apester-media tag to AMP (ampproject#4291)
f62cfb1 
* Initial implementation of <amp-apester-media>
- no playlist support yet
- public stage3-renderer doesn't send 'embed-size' with amp sentinel yet.

* lint
getWin() removed

* remove width from test

* Initial implementation of <amp-apester-media>
- no playlist support yet
- public stage3-renderer doesn't send 'embed-size' with amp sentinel yet.

* lint
getWin() removed

* remove width from test

* isLayoutSupported uncommented, support only fixed height

* pr comments fixes
- lint

* fix ident

* fix imports

* removed loader from PR

* -added random playlist support
-add preconnect to display service
-querying media on layoutCallback

* - sending 'seen' events

* added html_format: AMP @powdercloud

* minor fixes, added mocha tests.

* updated encoding/decoding
removed apester css prefixes
removed height attribute changes -> now changeHeight handle this.
note: I had to put setTimeout on height check cause it seems like this test happens before the attemptChangeHeight actually change this value.

* new line in test-amp-apester-media

* validator fix

* validator fix ampproject#2

* removed decodeUrl

* css in code changes

* validator fix: data-apester-media to data-apester-media-id
@weeblr weeblr mentioned this issue Mar 7, 2017
Closed
@cramforce cramforce mentioned this issue Apr 4, 2017
Closed
2 tasks
@alanorozco alanorozco mentioned this issue Apr 12, 2017
Closed
@dvoytenko dvoytenko mentioned this issue Apr 28, 2017
Closed
@rsimha rsimha mentioned this issue May 1, 2017
Closed
@dreamofabear dreamofabear mentioned this issue May 24, 2017
Closed
@jonkeller jonkeller mentioned this issue Jun 1, 2017
Closed
@jasonpang jasonpang mentioned this issue Jul 1, 2017
Closed
@johnpallett johnpallett mentioned this issue Aug 17, 2017
Closed
@jonkeller jonkeller mentioned this issue Sep 29, 2017
Merged
@jaygray0919 jaygray0919 mentioned this issue Nov 14, 2017
Closed
dreamofabear pushed a commit to dreamofabear/amphtml that referenced this issue Dec 8, 2017
attempt fix ampproject#2
01bce3e
@dreamofabear dreamofabear mentioned this issue Dec 27, 2017
Closed
@calebcordry calebcordry mentioned this issue Jan 3, 2018
Closed
glevitzky added a commit to glevitzky/amphtml that referenced this issue Jan 12, 2018
@glevitzky
Yarn attempt ampproject#2.
e36b102
glevitzky added a commit to glevitzky/amphtml that referenced this issue Jan 30, 2018
@glevitzky
Yarn attempt ampproject#2.
860c10e
@mborof mborof mentioned this issue Jan 8, 2020
Closed
@samouri samouri mentioned this issue Jan 15, 2020
Merged
@jyn15 jyn15 mentioned this issue Jan 29, 2020
Closed
@morsssss morsssss mentioned this issue Jan 30, 2020
Closed
@zhouyx zhouyx mentioned this issue Feb 6, 2020
Open
@lichinshao lichinshao mentioned this issue Mar 27, 2020
Closed
@Gregable Gregable mentioned this issue Mar 30, 2020
Closed
@stephengardner stephengardner mentioned this issue Apr 23, 2020
Open
@zhouyx zhouyx mentioned this issue May 26, 2020
Closed
@glevitzky glevitzky mentioned this issue Jun 11, 2020
Merged
@zhouyx zhouyx mentioned this issue Jun 23, 2020
Closed
@morsssss morsssss mentioned this issue Aug 12, 2020
Merged
@Gregable Gregable mentioned this issue Sep 21, 2020
Open
krdwan added a commit that referenced this issue Oct 20, 2020
@krdwan
✨ [bento][amp-accordion] CSS Port draft for amp accordion (PR #2) (#3…
21d8e50 
…0622)

* Update CSS for accordion

* Add JSX into Preact component styling and misc review comments

* Add important to make section styles impossible to overwrite

* Add tests for CSS in amp-accordion

* Accordion tests updates

* Removed tests for getComputedStyle

* Remove debugging comments

* Address nits from review
ed-bird pushed a commit to ed-bird/amphtml that referenced this issue Dec 10, 2020
@krdwan @ed-bird
✨ [bento][amp-accordion] CSS Port draft for amp accordion (PR ampproj…
6c8c3c0 
…ect#2) (ampproject#30622)

* Update CSS for accordion

* Add JSX into Preact component styling and misc review comments

* Add important to make section styles impossible to overwrite

* Add tests for CSS in amp-accordion

* Accordion tests updates

* Removed tests for getComputedStyle

* Remove debugging comments

* Address nits from review
cosmin-vi referenced this issue in cosmin-vi/amphtml Jan 6, 2021
@cosmin-vi
Add Video Intelligence Player extension #2
180357f
@kristoferbaxter kristoferbaxter mentioned this issue Jan 28, 2021
Closed
ychsieh added a commit that referenced this issue Mar 12, 2021
@ychsieh
Fix source glob error #2.
84ca57a
@goonydev goonydev mentioned this issue Jun 16, 2021
Closed
rileyajones referenced this issue in rileyajones/amphtml Jun 16, 2021
@rileyajones
commit #2 a valid (useless) commit
0867cb0
@MadisonMiner MadisonMiner mentioned this issue Jun 22, 2021
Closed
ychsieh added a commit that referenced this issue Jun 30, 2021
@ychsieh
🚮 Assist.js: Remove assistjs extension and all relevant libraries. (#…
fec8b59 
…35023)

* Add runtime service to handle execute tasks like adding ports to the network.
- Add entry points to wrapper such as creating PortOperator and adding ports.
- Update compile script since it can perform as normal Closure compiler.

* Fix lint errors.

* Remove externs.js since the compiled code with it would keep 'goog' hence violate JSC_CANNOT_HAVE_MODULE_VAR_NAMED_GOOG.

* Construct channel with FrameService iframe and add it to the network.
- Add DeferredChannel to the network first and resolve it after the real channel is constructed.
- Ensure FrameService port is always added before any widget initialization

* Report available widgets to FrameService so that it can request widget ports to listen on.
- Add protocol buffer library to generate FrameService protocol
- Report widget by sending messages to FrameService's RespondingChannel.
- Add necessary endpoints to Closure custom API.

* Move proto library to third_party folder.
- Move entire proto folder to third_party folder
- Update whitelist and source globs for new third_party library
- Add exports file so that 'require' can be avoided in the extension

* Fix source glob error.

* Fix source glob error #2.

* Update protoc from protobug Github repo.

* Remove assistjs extension and all relevant libraries.
@kristoferbaxter kristoferbaxter mentioned this issue Jul 28, 2021
Closed
UpScore-Matija pushed a commit to UpScore-Matija/amphtml that referenced this issue Oct 8, 2021
@MatijaA
fix tests ampproject#2
c26b360
@rileyajones rileyajones mentioned this issue Oct 11, 2021
Merged
@mszylkowski mszylkowski mentioned this issue Dec 6, 2021
Merged
ychsieh added a commit to ychsieh/amphtml that referenced this issue Jan 20, 2022
@ychsieh
Huge commit ampproject#2.
24fed59
@newmuis newmuis mentioned this issue Mar 1, 2022
Closed
@jpettitt jpettitt mentioned this issue Oct 24, 2022
Open
@jaygray0919 jaygray0919 mentioned this issue Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwinmombay erwinmombay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cramforce @erwinmombay