Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Percy to travis #8340

Closed
erwinmombay opened this issue Mar 23, 2017 · 3 comments
Closed

Integrate Percy to travis #8340

erwinmombay opened this issue Mar 23, 2017 · 3 comments
Assignees
@rsimha
Labels
P3: When Possible WG: infra
Milestone
Sprint H1 May

Comments

@erwinmombay
Copy link
Member

erwinmombay commented Mar 23, 2017 •
edited by rsimha
Loading

No description provided.

@ampwafflebot ampwafflebot added this to the New FRs milestone Mar 24, 2017
@rsimha rsimha modified the milestones: Fixit Week EOQ1, New FRs Mar 27, 2017
@rsimha rsimha mentioned this issue Apr 17, 2017
Closed
@rsimha rsimha modified the milestones: Sprint H2 April, Backlog Bugs Apr 17, 2017
@rsimha
Copy link
Contributor

rsimha commented Apr 17, 2017

Working on it during this week's sprint.

This was referenced Apr 26, 2017
Closed
Merged
Merged
Merged
@rsimha
Copy link
Contributor

rsimha commented May 1, 2017 •
edited
Loading

This issue should ideally be split into 3 issues:

  1. Create and configure a Percy account and associate it with ampproject/amphtml
  2. Create a new task "gulp visual-diff" and integrate it with the Percy toolchain
  3. Integrate "gulp visual-diff" with the Travis CI workflow

Status as of May 1st sprint planning: 1 is complete, 2 is complete* (under final review), and 3 is blocked by additional quota requirements to scale to serve the team's needs.

This was referenced May 1, 2017
Closed
Closed
Closed
@rsimha rsimha modified the milestones: Sprint H1 May, Sprint H2 April May 1, 2017
This was referenced May 10, 2017
Closed
Merged
Merged
Merged
@rsimha
Copy link
Contributor

rsimha commented May 15, 2017

With the above PRs, this issue can be closed. Scaling up the number of snapshot tests will be tracked in a different issue.

@rsimha rsimha closed this as completed May 15, 2017
@rsimha rsimha mentioned this issue May 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsimha rsimha

Labels
P3: When Possible WG: infra
Projects
None yet
Milestone
Sprint H1 May
Development

No branches or pull requests
3 participants
@erwinmombay @ampwafflebot @rsimha