Online iframe resizing rules with fallback. #790
Conversation
| win.addEventListener('message', function(event) { | ||
| if (event.origin != origin) { | ||
| if (origin != '*' && event.origin != origin) { |
There was a problem hiding this comment.
Why this? We should be able to calculate the origin of the iframe and only accept that.
There was a problem hiding this comment.
To avoid races: How about tagging the message here as to whether it came from the active element?
There was a problem hiding this comment.
What about srcdoc?
There was a problem hiding this comment.
RE: races. Good idea. Will do.
There was a problem hiding this comment.
With respect to srcdoc (which we currently don't support, but I'm working on right now) this is probably OK since we do check the source window.
There was a problem hiding this comment.
"OK" as in let's keep ''? Or let's get origin from URL assuming that you will always convert srcdoc to a data URL? I likewise judged '' this to be ok since we always check on source window.
|
The latest push includes:
|
|
Scroll adjustment is removed from this PR. |
dvoytenko
force-pushed
the
iframe-resize1
branch
from
48ba020
to
60efa27
Compare
| } | ||
| }; | ||
| this.blurCapture_ = e => { | ||
| timer.delay(() => { |
There was a problem hiding this comment.
Nice. You need to document this :)
|
LGTM |
|
The spec is changed to looking for |
|
I'd prefer resizable to be a bare attribute without any value. Otherwise LGTM |
| newHeight: newHeight, | ||
| force: force, | ||
| fallback: fallback | ||
| }); |
There was a problem hiding this comment.
probably not a part of our style guide but a nice to know, is ES2015 Object Literal Property Value Shorthand. (when key and the value have the same identifier)
this.changeHeightRequests_.push({
resource,
newHeight,
force,
fallback
});There was a problem hiding this comment.
Good to know. Do we have a compiler for this?
There was a problem hiding this comment.
yep, this should work with babel-core (no helpers required). not sure if closure-compiler has support for it, which is why i hazard supporting us to use it 😸
|
@cramforce Yes, definitely makes sense. Switch to no-value attribute. |
dvoytenko
force-pushed
the
iframe-resize1
branch
2 times, most recently
from
8894606
to
339bafc
Compare
dvoytenko
force-pushed
the
iframe-resize1
branch
from
5501faa
to
69a4fbb
Compare
Online iframe resizing rules with fallback.
|
Hi, It seems if we leave out "allow-same-origin" from the sanbox policy, the iframe resize does not work at all. is there a workaround for this? please help! Thanks, |
|
@antipath Could you please file a separate bug for this since this is a closed pull request? |
Closes #728.
Still working on docs...