Skip to content

Commit

Permalink
🚮 Assist.js: Remove assistjs extension and all relevant libraries. (#…
Browse files Browse the repository at this point in the history
…35023)

* Add runtime service to handle execute tasks like adding ports to the network.
- Add entry points to wrapper such as creating PortOperator and adding ports.
- Update compile script since it can perform as normal Closure compiler.

* Fix lint errors.

* Remove externs.js since the compiled code with it would keep 'goog' hence violate JSC_CANNOT_HAVE_MODULE_VAR_NAMED_GOOG.

* Construct channel with FrameService iframe and add it to the network.
- Add DeferredChannel to the network first and resolve it after the real channel is constructed.
- Ensure FrameService port is always added before any widget initialization

* Report available widgets to FrameService so that it can request widget ports to listen on.
- Add protocol buffer library to generate FrameService protocol
- Report widget by sending messages to FrameService's RespondingChannel.
- Add necessary endpoints to Closure custom API.

* Move proto library to third_party folder.
- Move entire proto folder to third_party folder
- Update whitelist and source globs for new third_party library
- Add exports file so that 'require' can be avoided in the extension

* Fix source glob error.

* Fix source glob error #2.

* Update protoc from protobug Github repo.

* Remove assistjs extension and all relevant libraries.
  • Loading branch information
ychsieh authored Jun 30, 2021
1 parent 8662b2b commit fec8b59
Show file tree
Hide file tree
Showing 27 changed files with 0 additions and 1,313 deletions.
8 changes: 0 additions & 8 deletions build-system/compile/bundles.config.extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -465,14 +465,6 @@
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-google-assistant-assistjs",
"version": "0.1",
"latestVersion": "0.1",
"options": {
"hasCss": true
}
},
{
"name": "amp-google-document-embed",
"version": "0.1",
Expand Down
1 change: 0 additions & 1 deletion build-system/compile/compile.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ function generateCompilerOptions(outputFilename, options) {
'third_party/amp-toolbox-cache-url/',
'third_party/caja/',
'third_party/closure-library/sha384-generated.js',
'third_party/closure-responding-channel',
'third_party/d3/',
'third_party/inputmask/',
'third_party/mustache/',
Expand Down
1 change: 0 additions & 1 deletion build-system/compile/sources.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ const COMMON_GLOBS = [
'third_party/amp-toolbox-cache-url/**/*.js',
'third_party/caja/html-sanitizer.js',
'third_party/closure-library/sha384-generated.js',
'third_party/closure-responding-channel/closure-bundle.js',
'third_party/css-escape/css-escape.js',
'third_party/d3/**/*.js',
'third_party/fuzzysearch/index.js',
Expand Down
1 change: 0 additions & 1 deletion build-system/test-configs/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ const htmlFixtureGlobs = [
'!examples/amp-consent/diy-3p-iframe-tcf-postmessage.html',
'!examples/amp-consent/diy-consent.html',
'!examples/amp-form.ssr.html',
'!examples/amp-google-assistant-assistjs.amp.html',
'!examples/amp-layout-intrinsic.amp.html',
'!examples/amp-lightbox.amp.html',
'!examples/amp-list-layout-container.amp.html',
Expand Down
1 change: 0 additions & 1 deletion build-system/test-configs/dep-check-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ exports.rules = [
'extensions/amp-subscriptions-google/**/*.js->third_party/subscriptions-project/swg-gaa.js',
'extensions/amp-subscriptions/**/*.js->third_party/subscriptions-project/aes_gcm.js',
'extensions/amp-subscriptions/**/*.js->third_party/subscriptions-project/config.js',
'extensions/amp-google-assistant-assistjs/**/*.js->third_party/closure-responding-channel/closure-bundle.js',
'src/core/dom/css-selectors.js->third_party/css-escape/css-escape.js',
'src/sanitizer.js->third_party/caja/html-sanitizer.js',
'src/shadow-embed.js->third_party/webcomponentsjs/ShadowCSS.js',
Expand Down
28 changes: 0 additions & 28 deletions examples/amp-google-assistant-assistjs.amp.html

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit fec8b59

Please sign in to comment.