-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update existing notebooks of examples #265
Conversation
a448a53
to
a4eb643
Compare
730b769
to
a15d939
Compare
a15d939
to
1a2d055
Compare
ReadTheDocs is currently failing to build the notebooks, any clue @flferretti? logs
|
I probably got it, I moved the import of the |
7427319
to
6f20c40
Compare
Then my guess is that the environment variable just gets ignored in this way. I'll check the changes to understand better this behavior |
6f20c40
to
1bf67ef
Compare
No what I meant is that it was my mistake since I moved the import without realizing of the introduced problem. Now I fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Diego!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit and then LGTM, thanks!
Co-authored-by: Filippo Luca Ferretti <[email protected]>
30f9484
to
bdf5c8e
Compare
Closing and reopening to trigger again ReadTheDocs CI |
📚 Documentation preview 📚: https://jaxsim--265.org.readthedocs.build//265/