Update setup.py #114
Merged
Update setup.py #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @rafaelrdealmeida! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-01-25 01:03:31 UTC |
pep8
This was referenced Jan 25, 2022
akamhy
added a commit
that referenced
this pull request
Jan 25, 2022
For some reason updates made at #114 are breaking the build using setup, caught while deploying to a cloud service provider. The exact error is: Traceback (most recent call last): File "<string>", line 1, in <module> File "/tmp/pip-req-build-n3b9e5pj/setup.py", line 5 os.path.join(os.path.dirname(__file__), README.md), encoding=utf-8), ^ SyntaxError: invalid syntax ---------------------------------------- ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output. See also : conda-forge/staged-recipes#17634
akamhy
reviewed
Jan 25, 2022
| @@ -1,11 +1,16 @@ | |||
| import os.path | |||
| from setuptools import setup | |||
|
|
|||
| with open(os.path.join(os.path.dirname(__file__), "README.md")) as f: | |||
| with open( | |||
| os.path.join(os.path.dirname(__file__), "README.md"), encoding="utf-8"), | |||
There was a problem hiding this comment.
I somehow missed it and the project doesn't build test via the CI. Fixed in #116.
There was a problem hiding this comment.
The issue is with the "," at the end of line 5.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #111 (comment)