Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py #114

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Update setup.py #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
759874c
Update setup.py
rafaelrdealmeida Jan 25, 2022
86a90a3
Update setup.py
rafaelrdealmeida Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
import os.path
from setuptools import setup

with open(os.path.join(os.path.dirname(__file__), "README.md")) as f:
with open(
os.path.join(os.path.dirname(__file__), "README.md"), encoding="utf-8"),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow missed it and the project doesn't build test via the CI. Fixed in #116.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is with the "," at the end of line 5.

as f:
long_description = f.read()

about = {}
with open(os.path.join(os.path.dirname(__file__), "waybackpy", "__version__.py")) as f:
with open(
os.path.join(os.path.dirname(__file__), "waybackpy", "__version__.py"),
encoding="utf-8")
as f:
exec(f.read(), about)

version = str(about["__version__"])
Expand Down