Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make available in conda-forge #111

Closed
rafaelrdealmeida opened this issue Jan 21, 2022 · 14 comments · Fixed by #122
Closed

make available in conda-forge #111

rafaelrdealmeida opened this issue Jan 21, 2022 · 14 comments · Fixed by #122
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@rafaelrdealmeida
Copy link
Contributor

Hi, are there any plans to make waybackpy available in conda-forge?

cheers

@akamhy
Copy link
Owner

akamhy commented Jan 21, 2022

@rafaelrdealmeida No and most likely not in 2022, but if you want you can create a PR at https://github.com/conda-forge/staged-recipes. I can link to it from the Readme of this repo.

Similar case:

I had no plans to create a docker image but SecSI (https://secsi.io), an Italian cybersecurity startup created a docker image and it is in fact linked from the readme of the repo.

@akamhy akamhy added enhancement New feature or request question Further information is requested good first issue Good for newcomers labels Jan 21, 2022
@rafaelrdealmeida
Copy link
Contributor Author

rafaelrdealmeida commented Jan 22, 2022

Hi @akamhy ,I will do this within a week!

Thanks for keeping waybackpy. He is very helpful to us!

If someone is using the anaconda virtual environment through the yaml file, until then you can do the following (works here)

(1) in linux terminal:

conda config --set pip_interop_enabled True

(2) see : conda/conda#10815 (comment)

@rafaelrdealmeida
Copy link
Contributor Author

update:

conda-forge/staged-recipes#17634

@rafaelrdealmeida
Copy link
Contributor Author

hi, how should I proceed? conda-forge/staged-recipes#17634

Nicholas Bollweg @bollwyvl 20:49
had to do this relatively recently: one option is to patch in open(encoding="utf-8")

Nicholas Bollweg @bollwyvl 20:51
I tackled it by:

rafaelrdealmeida added a commit to rafaelrdealmeida/waybackpy that referenced this issue Jan 25, 2022
akamhy added a commit that referenced this issue Jan 25, 2022
@akamhy
Copy link
Owner

akamhy commented Jan 25, 2022

PR #114 is now merged, I believe now there should be no more issues.

@akamhy
Copy link
Owner

akamhy commented Jan 25, 2022

PR #114 is now merged, I believe now there should be no more issues.

Okay, I was wrong. see https://github.com/akamhy/waybackpy/pull/114/files#r791431485

Also I should add a build test along with the code-style and unittests. I also failed to catch the syntax issue.

@akamhy
Copy link
Owner

akamhy commented Jan 25, 2022

Also I should add a build test along with the code-style and unittests. I also failed to catch the syntax issue.

Build test added #118.

@rafaelrdealmeida
Copy link
Contributor Author

rafaelrdealmeida commented Jan 25, 2022

update, see PR: conda-forge/staged-recipes#17643

@rafaelrdealmeida
Copy link
Contributor Author

@akamhy , how is the figlet generated?

waybackpy/waybackpy/cli.py

Lines 172 to 179 in 4408c5e

┏┓┏┓┏┓━━━━━━━━━━┏━━┓━━━━━━━━━━┏┓━━┏━━━┓━━━━━
┃┃┃┃┃┃━━━━━━━━━━┃┏┓┃━━━━━━━━━━┃┃━━┃┏━┓┃━━━━━
┃┃┃┃┃┃┏━━┓━┏┓━┏┓┃┗┛┗┓┏━━┓━┏━━┓┃┃┏┓┃┗━┛┃┏┓━┏┓
┃┗┛┗┛┃┗━┓┃━┃┃━┃┃┃┏━┓┃┗━┓┃━┃┏━┛┃┗┛┛┃┏━━┛┃┃━┃┃
┗┓┏┓┏┛┃┗┛┗┓┃┗━┛┃┃┗━┛┃┃┗┛┗┓┃┗━┓┃┏┓┓┃┃━━━┃┗━┛┃
━┗┛┗┛━┗━━━┛┗━┓┏┛┗━━━┛┗━━━┛┗━━┛┗┛┗┛┗┛━━━┗━┓┏┛
━━━━━━━━━━━┏━┛┃━━━━━━━━━━━━━━━━━━━━━━━━┏━┛┃━
━━━━━━━━━━━┗━━┛━━━━━━━━━━━━━━━━━━━━━━━━┗━━┛━

see: conda-forge/staged-recipes#17643 (comment)

@akamhy
Copy link
Owner

akamhy commented Jan 25, 2022

@akamhy , how is the figlet generated?

I don't remember but it was possibly from some website and it is not in ASCII characters.

Maybe I should replace it with the ASCII version below and create a new release? @rafaelrdealmeida

                     _                _                
                    | |              | |               
__      ____ _ _   _| |__   __ _  ___| | ___ __  _   _ 
\ \ /\ / / _` | | | | '_ \ / _` |/ __| |/ / '_ \| | | |
 \ V  V / (_| | |_| | |_) | (_| | (__|   <| |_) | |_| |
  \_/\_/ \__,_|\__, |_.__/ \__,_|\___|_|\_\ .__/ \__, |
                __/ |                     | |     __/ |
               |___/                      |_|    |___/ 

@akamhy
Copy link
Owner

akamhy commented Jan 25, 2022

I have replaced the non-ASCII figlet with the ASCII figlet. See 5ea1d3b

@rafaelrdealmeida
Copy link
Contributor Author

rafaelrdealmeida commented Jan 25, 2022

@akamhy now it's gone, thanks a lot for the help! I put you on the maintainers list too.

When the package is published on conda-forge I can add this in the "Installation" item if you want

see conda-forge/staged-recipes#17643
cheers

@rafaelrdealmeida
Copy link
Contributor Author

rafaelrdealmeida commented Jan 25, 2022

  • add conda-forge in the "Installation"

@rafaelrdealmeida
Copy link
Contributor Author

I added description in the meta.yaml of the conda-forge package. I believe it helps that more people find the package

https://github.com/conda-forge/waybackpy-feedstock/blob/master/recipe/meta.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants