-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding waybackpy #17634
adding waybackpy #17634
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/waybackpy:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core, please help. |
@conda-forge-admin, please restart ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error on the Windows build is coming from the setup.py script where the long_description
is read in from README.md
. This decoding error shouldn't be a problem since the package is being build noarch, so when published to the feedstock, it should only be building on Linux.
To fix this error, the setup.py would need to be patched to include the encoding parameter for file opens. i.e.
file = open(filename, encoding="utf8")
Processing c:\bld\waybackpy_1643067728345\work
Added file:///C:/bld/waybackpy_1643067728345/work to build tracker 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-req-tracker-5cp1337n'
Running setup.py (path:%SRC_DIR%\setup.py) egg_info for package from file:///C:/bld/waybackpy_1643067728345/work
Created temporary directory: C:\Users\VssAdministrator\AppData\Local\Temp\pip-pip-egg-info-2s070sxd
Preparing metadata (setup.py): started
Running command python setup.py egg_info
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "C:\bld\waybackpy_1643067728345\work\setup.py", line 5, in <module>
long_description = f.read()
File "C:\bld\waybackpy_1643067728345\_h_env\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 1196: character maps to <undefined>
Preparing metadata (setup.py): finished with status 'error'
I've merged the PR which includes the encoding parameter(akamhy/waybackpy#114), please run the tests again. |
For some reason updates made at #114 are breaking the build using setup, caught while deploying to a cloud service provider. The exact error is: Traceback (most recent call last): File "<string>", line 1, in <module> File "/tmp/pip-req-build-n3b9e5pj/setup.py", line 5 os.path.join(os.path.dirname(__file__), README.md), encoding=utf-8), ^ SyntaxError: invalid syntax ---------------------------------------- ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output. See also : conda-forge/staged-recipes#17634
It's true, but the point of noarch packages is kind of that they are portable. Having a broken dev process on windows can be a hindrance to a potential contributor using that platform, for example.
Running the tests again and expecting a different out would require one of:
|
I just upstreamed v3.0.1 on PyPi(option 2). @rafaelrdealmeida please update the version and sha256 hash digest on the PR. |
see: #17643 |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).