Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding waybackpy #17634

Closed
wants to merge 2 commits into from
Closed

adding waybackpy #17634

wants to merge 2 commits into from

Conversation

rafaelrdealmeida
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/waybackpy) and found some lint.

Here's what I've got...

For recipes/waybackpy:

  • The recipe must have a build/number section.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/waybackpy) and found it was in an excellent condition.

@rafaelrdealmeida
Copy link
Contributor Author

@conda-forge/core, please help.

@rafaelrdealmeida
Copy link
Contributor Author

@conda-forge-admin, please restart ci

Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error on the Windows build is coming from the setup.py script where the long_description is read in from README.md. This decoding error shouldn't be a problem since the package is being build noarch, so when published to the feedstock, it should only be building on Linux.

To fix this error, the setup.py would need to be patched to include the encoding parameter for file opens. i.e.

file = open(filename, encoding="utf8")
Processing c:\bld\waybackpy_1643067728345\work
  Added file:///C:/bld/waybackpy_1643067728345/work to build tracker 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-req-tracker-5cp1337n'
  Running setup.py (path:%SRC_DIR%\setup.py) egg_info for package from file:///C:/bld/waybackpy_1643067728345/work
  Created temporary directory: C:\Users\VssAdministrator\AppData\Local\Temp\pip-pip-egg-info-2s070sxd
  Preparing metadata (setup.py): started
  Running command python setup.py egg_info
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "C:\bld\waybackpy_1643067728345\work\setup.py", line 5, in <module>
      long_description = f.read()
    File "C:\bld\waybackpy_1643067728345\_h_env\lib\encodings\cp1252.py", line 23, in decode
      return codecs.charmap_decode(input,self.errors,decoding_table)[0]
  UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 1196: character maps to <undefined>
  Preparing metadata (setup.py): finished with status 'error'

@akamhy
Copy link
Member

akamhy commented Jan 25, 2022

I've merged the PR which includes the encoding parameter(akamhy/waybackpy#114), please run the tests again.

akamhy added a commit to akamhy/waybackpy that referenced this pull request Jan 25, 2022
For some reason updates made at #114
are breaking the build using setup, caught while deploying to a cloud service
provider.

The exact error is:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/pip-req-build-n3b9e5pj/setup.py", line 5
  os.path.join(os.path.dirname(__file__), README.md), encoding=utf-8),
                                                                                ^
SyntaxError: invalid syntax
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

See also :
conda-forge/staged-recipes#17634
@bollwyvl
Copy link
Contributor

should only be building on Linux.

It's true, but the point of noarch packages is kind of that they are portable. Having a broken dev process on windows can be a hindrance to a potential contributor using that platform, for example.

please run the tests again.

Running the tests again and expecting a different out would require one of:

  • on this PR, adding a patches section (it's a list) under source referring to a patch in that folder
    • e.g. 0000-read-with-utf8.patch, the output of diff -u v3.0.0 master -- setup.py > 0000-read-with-utf8.patch
  • or an upstream v3.0.1 in PyPI...
    • on this PR, updating the version and hash accordingly

@akamhy
Copy link
Member

akamhy commented Jan 25, 2022

Running the tests again and expecting a different out would require one of:

* on this PR, adding a `patches` section (it's a list) under `source` referring to a patch in that folder
  
  * e.g. `0000-read-with-utf8.patch`, the output of `diff -u v3.0.0 master -- setup.py > 0000-read-with-utf8.patch`

* or an upstream `v3.0.1` in PyPI...
  
  * on this PR, updating the version and hash accordingly

I just upstreamed v3.0.1 on PyPi(option 2).

@rafaelrdealmeida please update the version and sha256 hash digest on the PR.

@rafaelrdealmeida
Copy link
Contributor Author

see: #17643

@rafaelrdealmeida rafaelrdealmeida mentioned this pull request Jan 25, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants