Switch to pnpm and restore @ember/test-helpers to latest patch
#894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
force-pushed
the
chore/switch-to-pnpm
branch
from
76ff0b5 to
7acd723
Compare
gilest
force-pushed
the
chore/switch-to-pnpm
branch
from
7acd723 to
1a316ae
Compare
gilest
force-pushed
the
chore/switch-to-pnpm
branch
from
8ef04de to
ae3573c
Compare
jelhan
approved these changes
Jan 20, 2023
| @@ -63,12 +63,16 @@ | |||
| "@babel/plugin-transform-runtime": "^7.18.2", | |||
| "@babel/plugin-transform-typescript": "^7.18.4", | |||
| "@babel/preset-typescript": "^7.17.12", | |||
| "@babel/runtime": "^7.20.7", | |||
| "@ember/string": "^3.0.1", | |||
There was a problem hiding this comment.
This may need to go into peerDependency to avoid a deprecation in Ember 4.10+. Adding as peer dependency would be a breaking change. Maybe better done in separate PR.
When doing a new major for that, we should also revisit other dependencies and see if they should be peer dependencies instead. E.g. @glimmer/tracking and @glimmer/component.
There was a problem hiding this comment.
Ah good point. Definitely better done in a separate PR!
There was a problem hiding this comment.
Added a tracking issue #899
gilest
changed the title
@ember/test-helpers to latest patch
Closed
Merged
gilest
added a commit
that referenced
this pull request
Dec 8, 2023
Some config adjustments since #1031 The private packages version numbers and dependency on ember-file-upload are being bumped. This causes the CI to fail after each release because a new lockfile was not generated We also want to keep the workspace:* dependency since we're using dependenciesMeta. We're using dependenciesMeta to get the best possible peerDependency resolution: Switch to pnpm and restore @ember/test-helpers to latest patch #894 Fix docs website peer dependency resolution #968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to continue to test Ember 3.28 via ember try.
I've been struggling with that particular build since: emberjs/ember-test-helpers#1232
To my best understanding a quirk in yarn's (incorrect) handling of peerDependencies with monorepo causes incorrect resolution of
ember-source.I wasn't able to find a
nohoistconfig with yarn which worked, although I'm open to suggestions.As suggested in this comment pnpm handles peerDeps more correctly, and provides the dependenciesMeta.*.injected option.
This issue has been blocking the release of
ember-file-uploadbecause this addon includes@ember/test-helpersin its own dependencies (we ship custom test helpers which depend on that package). I don't want to cut a release with a restrictive@ember/test-helpersdependency version.