Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move release-it to the root, add root scripts #1031

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Dec 1, 2023

This just makes things easier to run from the root for both releases and general testing and debugging.

@RobbieTheWagner RobbieTheWagner merged commit 2ce186b into master Dec 1, 2023
15 checks passed
@RobbieTheWagner RobbieTheWagner deleted the move-release-it-to-root branch December 1, 2023 19:55
@gilest gilest mentioned this pull request Dec 7, 2023
gilest added a commit that referenced this pull request Dec 7, 2023
Since #1031 running local commands like pnpm install causes the addon build to run twice.

This is because we added a workspace-level prepare script while leaving the package-level prepare script in place.

This PR removes the workspace-level prepare script to restore a single build being run.
@gilest gilest mentioned this pull request Dec 8, 2023
gilest added a commit that referenced this pull request Dec 8, 2023
Some config adjustments since #1031

The private packages version numbers and dependency on ember-file-upload are being bumped. This causes the CI to fail after each release because a new lockfile was not generated

We also want to keep the workspace:* dependency since we're using dependenciesMeta.

We're using dependenciesMeta to get the best possible peerDependency resolution:

Switch to pnpm and restore @ember/test-helpers to latest patch #894
Fix docs website peer dependency resolution #968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant