-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit peerDependencies #899
Comments
My comment was only meant for |
I'm not an expert on that topic but we should investigate if the following dependencies and dev dependencies should go into peer dependencies:
Most of them are already part of the apps blueprint. For |
Regarding the
@bertdeblock can we safely ignore this in a v2 addon? |
Indeed, v2 addons don't use |
It's a required peer dependency since ember-source 4.10.0. The deprecation is now a removal in canary v5 which is causing a CI failure. Same change would have been made in the ember-cil 4.12 blueprint but hoping to get the CI green with a minimal change first. Related to #899 as I'm not sure we need to declare a peerDependency from the addon itself. Reason for this is don't think the addon uses @ember/string.
Pulled out of #894 where
devDependencies
have been added to@babel/runtime
and@ember/string
.As suggested by @jelhan
The text was updated successfully, but these errors were encountered: