Move blueprint provided packages to peerDependencies #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
commented
Apr 7, 2023
Comment on lines
105
to
113
| "peerDependencies": { | ||
| "@ember/test-helpers": "^2.9.3", | ||
| "@glimmer/component": "^1.1.2", | ||
| "@glimmer/tracking": "^1.1.2", | ||
| "ember-cli-mirage": "*", | ||
| "miragejs": "*" | ||
| "ember-modifier": "^3.2.7 || ^4.1.0", | ||
| "miragejs": "*", | ||
| "tracked-built-ins": "^3.1.1" | ||
| }, |
There was a problem hiding this comment.
Everything I've moved to peerDependencies is in the modern ember-cli blueprints.
gilest
commented
Apr 7, 2023
Comment on lines
48
to
53
| "dependencies": { | ||
| "@ember/test-helpers": "^2.9.3", | ||
| "@ember/test-waiters": "^3.0.0", | ||
| "@embroider/addon-shim": "^1.5.0", | ||
| "@embroider/macros": "^1.0.0", | ||
| "@glimmer/component": "^1.0.4", | ||
| "@glimmer/tracking": "^1.0.4", | ||
| "ember-auto-import": "^2.0.0", | ||
| "ember-modifier": "^3.2.7 || ^4.0.0", | ||
| "tracked-built-ins": "^3.0.0" | ||
| "ember-auto-import": "^2.0.0" | ||
| }, |
There was a problem hiding this comment.
Believe the remaining dependencies are required. Keen for others to check this, though.
gilest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment to see how we might fix #899
Being aggressive here and moving as much as possible from
dependenciestodevDependenciesin an attempt to batch breaking changes and avoid another major.