feat: geometry id generation for detector - ODD light part 3 #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
niermann999
reviewed
Sep 14, 2023
Tests/CommonHelpers/Acts/Tests/CommonHelpers/DetectorElementStub.hpp
Outdated
Show resolved
Hide resolved
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
…2451) Prompted through comments in #2439 This PR harmonies the constructor signature for surfaces with detector elements and bounds, it fixes also a bug in the cylinder surface that a `shared_ptr` is first moved then assert checked, if this was the sole occurrence, e.g. by construction `Constructor(std::make_shared<Foo>` the assert would have always fired.
niermann999
previously approved these changes
Sep 15, 2023
acts-policybot
bot
dismissed
niermann999’s stale review
Invalidated by push of ae5d56a
Codecov Report
@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
+ Coverage 49.78% 49.81% +0.03%
==========================================
Files 461 464 +3
Lines 26015 26121 +106
Branches 11921 11980 +59
==========================================
+ Hits 12952 13013 +61
+ Misses 4610 4608 -2
- Partials 8453 8500 +47
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Will be superseded by a squashed version. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
This PR introduces: - an interface of a `Acts::Experimental::IGeometryIdGenerator` tool - a standard `Acts::Experimental::GeometryIdGenerator` implementation - slots in the detector building to attach those generators - a check in the `Acts::Detector` class that surfaces have unique geometry ids - a `Acts::GeometryHierarchyMap<Surface>` for the detector - unit tests for all of those - finally the ODD light with geometry id settings as the ODD standard This is a squashed version of #2439 - It sits on top of #2424 and #2436 and will wait until those are merged.
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
This PR introduces: - an interface of a `Acts::Experimental::IGeometryIdGenerator` tool - a standard `Acts::Experimental::GeometryIdGenerator` implementation - slots in the detector building to attach those generators - a check in the `Acts::Detector` class that surfaces have unique geometry ids - a `Acts::GeometryHierarchyMap<Surface>` for the detector - unit tests for all of those - finally the ODD light with geometry id settings as the ODD standard This is a squashed version of acts-project#2439 - It sits on top of acts-project#2424 and acts-project#2436 and will wait until those are merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
Acts::Experimental::IGeometryIdGeneratortoolActs::Experimental::GeometryIdGeneratorimplementationActs::Detectorclass that surfaces have unique geometry idsActs::GeometryHierarchyMap<Surface>for the detectorIt sits on top of #2424 and #2436 and will wait until those are merged.