feat: Geometry ID Generator aka ODD light part3 #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a squashed versions of the part3 for the ODD because I had to bounce back and forth for the debug CI to be fixed. |
asalzburger
changed the title
github-actions
bot
added
Component - Core
niermann999
previously approved these changes
Sep 19, 2023
acts-policybot
bot
dismissed
niermann999’s stale review
Invalidated by push of 18d045b
Codecov Report
@@ Coverage Diff @@
## main #2462 +/- ##
==========================================
+ Coverage 49.78% 49.81% +0.03%
==========================================
Files 461 464 +3
Lines 26023 26135 +112
Branches 11921 11982 +61
==========================================
+ Hits 12955 13019 +64
Misses 4616 4616
- Partials 8452 8500 +48
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Has been already approved, clang-tidy fix afterwards. |
|
Hey @niermann999 - I had to do some clang-tidy and CI fixing, which invalidated your approval. |
niermann999
approved these changes
Sep 19, 2023
acts-project-service
added
the
Breaks Athena build
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
This PR introduces: - an interface of a `Acts::Experimental::IGeometryIdGenerator` tool - a standard `Acts::Experimental::GeometryIdGenerator` implementation - slots in the detector building to attach those generators - a check in the `Acts::Detector` class that surfaces have unique geometry ids - a `Acts::GeometryHierarchyMap<Surface>` for the detector - unit tests for all of those - finally the ODD light with geometry id settings as the ODD standard This is a squashed version of acts-project#2439 - It sits on top of acts-project#2424 and acts-project#2436 and will wait until those are merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
Acts::Experimental::IGeometryIdGeneratortoolActs::Experimental::GeometryIdGeneratorimplementationActs::Detectorclass that surfaces have unique geometry idsActs::GeometryHierarchyMap<Surface>for the detectorThis is a squashed version of #2439 - It sits on top of #2424 and #2436 and will wait until those are merged.