-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add volume grid start lookup - ODD light part 2 #2436
feat: add volume grid start lookup - ODD light part 2 #2436
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2436 +/- ##
=======================================
Coverage 49.70% 49.71%
=======================================
Files 458 461 +3
Lines 25949 25988 +39
Branches 11919 11939 +20
=======================================
+ Hits 12899 12920 +21
- Misses 4596 4598 +2
- Partials 8454 8470 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Core/include/Acts/Detector/detail/CylindricalDetectorHelper.hpp
Outdated
Show resolved
Hide resolved
Core/include/Acts/Detector/detail/CylindricalDetectorHelper.hpp
Outdated
Show resolved
Hide resolved
Core/include/Acts/Detector/detail/CylindricalDetectorHelper.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Geometry/include/ActsExamples/Geometry/VolumeAssociationTest.hpp
Show resolved
Hide resolved
Examples/Algorithms/Geometry/include/ActsExamples/Geometry/VolumeAssociationTest.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Geometry/include/ActsExamples/Geometry/VolumeAssociationTest.hpp
Outdated
Show resolved
Hide resolved
Core/include/Acts/Detector/detail/CylindricalDetectorHelper.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Joana Niermann <[email protected]>
Invalidated by push of 9fff7f2
Hi @niermann999 - can you press the approve button again, please? I committed your comment update - and that invalidated the approval. |
This PR introduces: - an interface of a `Acts::Experimental::IGeometryIdGenerator` tool - a standard `Acts::Experimental::GeometryIdGenerator` implementation - slots in the detector building to attach those generators - a check in the `Acts::Detector` class that surfaces have unique geometry ids - a `Acts::GeometryHierarchyMap<Surface>` for the detector - unit tests for all of those - finally the ODD light with geometry id settings as the ODD standard This is a squashed version of #2439 - It sits on top of #2424 and #2436 and will wait until those are merged.
This PR introduces: - an interface of a `Acts::Experimental::IGeometryIdGenerator` tool - a standard `Acts::Experimental::GeometryIdGenerator` implementation - slots in the detector building to attach those generators - a check in the `Acts::Detector` class that surfaces have unique geometry ids - a `Acts::GeometryHierarchyMap<Surface>` for the detector - unit tests for all of those - finally the ODD light with geometry id settings as the ODD standard This is a squashed version of acts-project#2439 - It sits on top of acts-project#2424 and acts-project#2436 and will wait until those are merged.
This PR adds the possibility to create a grid based start volume lookup for navigation. It reduces the time for 1000 lookups in the ODD light example from
20 ms
to1.5 ms
and hence1.5 µs
per lookup.This sits on top of #2424 and will wait until this one is merged.