Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add volume grid start lookup - ODD light part 2 #2436

Merged
merged 19 commits into from
Sep 13, 2023

Conversation

asalzburger
Copy link
Contributor

This PR adds the possibility to create a grid based start volume lookup for navigation. It reduces the time for 1000 lookups in the ODD light example from 20 ms to 1.5 ms and hence 1.5 µs per lookup.

This sits on top of #2424 and will wait until this one is merged.

@asalzburger asalzburger added this to the next milestone Sep 11, 2023
@asalzburger asalzburger changed the title feat: add volume grid start lookup - ODD Light Part 2 feat: add volume grid start lookup - ODD light part 2 Sep 11, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation labels Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #2436 (d9ed6b9) into main (b406627) will increase coverage by 0.00%.
The diff coverage is 55.00%.

❗ Current head d9ed6b9 differs from pull request most recent head 9fff7f2. Consider uploading reports for the commit 9fff7f2 to get more accurate results

@@           Coverage Diff           @@
##             main    #2436   +/-   ##
=======================================
  Coverage   49.70%   49.71%           
=======================================
  Files         458      461    +3     
  Lines       25949    25988   +39     
  Branches    11919    11939   +20     
=======================================
+ Hits        12899    12920   +21     
- Misses       4596     4598    +2     
- Partials     8454     8470   +16     
Files Changed Coverage Δ
...lude/Acts/Detector/CylindricalContainerBuilder.hpp 100.00% <ø> (ø)
Core/src/Detector/CylindricalContainerBuilder.cpp 49.25% <0.00%> (-2.31%) ⬇️
.../src/Detector/detail/CylindricalDetectorHelper.cpp 32.96% <ø> (-1.70%) ⬇️
.../Acts/Detector/detail/IndexedSurfacesGenerator.hpp 60.00% <50.00%> (ø)
...re/src/Detector/IndexedRootVolumeFinderBuilder.cpp 54.54% <54.54%> (ø)
...Acts/Detector/detail/CylindricalDetectorHelper.hpp 59.52% <58.53%> (ø)
...ts/Detector/interface/IRootVolumeFinderBuilder.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@asalzburger asalzburger added the 🛑 blocked This item is blocked by another item label Sep 12, 2023
@asalzburger asalzburger removed the 🛑 blocked This item is blocked by another item label Sep 12, 2023
@github-actions github-actions bot removed Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation labels Sep 12, 2023
@github-actions github-actions bot added Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation Seeding labels Sep 13, 2023
@asalzburger
Copy link
Contributor Author

Hi @niermann999 - can you press the approve button again, please? I committed your comment update - and that invalidated the approval.

@kodiakhq kodiakhq bot merged commit 817c58c into acts-project:main Sep 13, 2023
57 checks passed
@paulgessinger paulgessinger modified the milestones: next, v29.2.0 Sep 15, 2023
kodiakhq bot pushed a commit that referenced this pull request Sep 20, 2023
This PR introduces:

- an interface of a `Acts::Experimental::IGeometryIdGenerator` tool
- a standard `Acts::Experimental::GeometryIdGenerator` implementation
- slots in the detector building to attach those generators
- a check in the `Acts::Detector` class that surfaces have unique geometry ids
- a `Acts::GeometryHierarchyMap<Surface>` for the detector
- unit tests for all of those
- finally the ODD light with geometry id settings as the ODD standard

This is a squashed version of #2439 -  It sits on top of #2424 and #2436 and will wait until those are merged.
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
This PR introduces:

- an interface of a `Acts::Experimental::IGeometryIdGenerator` tool
- a standard `Acts::Experimental::GeometryIdGenerator` implementation
- slots in the detector building to attach those generators
- a check in the `Acts::Detector` class that surfaces have unique geometry ids
- a `Acts::GeometryHierarchyMap<Surface>` for the detector
- unit tests for all of those
- finally the ODD light with geometry id settings as the ODD standard

This is a squashed version of acts-project#2439 -  It sits on top of acts-project#2424 and acts-project#2436 and will wait until those are merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants