feat: harmonize shared ptr usage for surfaces with detector elements

[asalzburger]

Prompted through comments in #2439

This PR harmonies the constructor signature for surfaces with detector elements and bounds, it fixes also a bug in the cylinder surface that a shared_ptr is first moved then assert checked, if this was the sole occurrence, e.g. by construction
Constructor(std::make_shared<Foo> the assert would have always fired.

[asalzburger]

Hey @niermann999 - you asked for it.

[codecov]

Codecov Report

Merging #2451 (688e198) into main (9e20cea) will not change coverage.
The diff coverage is 63.63%.

@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         461      461           
  Lines       25989    25989           
  Branches    11934    11934           
=======================================
  Hits        12921    12921           
  Misses       4600     4600           
  Partials     8468     8468           

Files Changed	Coverage Δ
Core/include/Acts/Surfaces/CylinderSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/DiscSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/PlaneSurface.hpp	100.00% <ø> (ø)
Core/src/Surfaces/CylinderSurface.cpp	37.98% <50.00%> (ø)
Core/src/Surfaces/DiscSurface.cpp	33.33% <66.66%> (ø)
Core/src/Surfaces/PlaneSurface.cpp	56.56% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 688e198

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data