Don't use @master in your workflow #41
Labels
Comments
|
Can we subscribe to this issue for further updates for v2 release? |
|
|
|
@mittalyashu The Once |
|
Sorry for the trouble, thanks for the heads up 😁 |
konradpabjan
changed the title
dreamer
added a commit
to dosbox-staging/dosbox-staging
that referenced
this issue
Jul 4, 2020
dreamer
added a commit
to dosbox-staging/dosbox-staging
that referenced
this issue
Jul 5, 2020
New stable version of this action has ability to upload a single file without explicitly naming it, but we can't use it because GitHub UI creates a placeholder name. Author of upload-artifact action clarified, that problem with downloading "zip" files is not caused by action, but by GitHub UI, therefore we can't remove unnecessary zip wrapper around Linux tarball nor macOS dmg file still. See: actions/upload-artifact#41
dreamer
added a commit
to dosbox-staging/dosbox-staging
that referenced
this issue
Jul 5, 2020
New stable version of this action has ability to upload a single file without explicitly naming it, but we can't use it because GitHub UI creates a placeholder name. Author of upload-artifact action clarified, that problem with downloading "zip" files is not caused by action, but by GitHub UI, therefore we can't remove unnecessary zip wrapper around Linux tarball nor macOS dmg file still. See: actions/upload-artifact#41
dreamer
added a commit
to dosbox-staging/dosbox-staging
that referenced
this issue
Jul 5, 2020
New stable version of this action has ability to upload a single file without explicitly naming it, but we can't use it because GitHub UI creates a placeholder name. Author of upload-artifact action clarified, that problem with downloading "zip" files is not caused by action, but by GitHub UI, therefore we can't remove unnecessary zip wrapper around Linux tarball nor macOS dmg file still. See: actions/upload-artifact#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During the beta of GitHub Actions, a lot of documentation (including the README for this action) showed example YAML with
masterbeing referenced:We currently encourage users to not use
masteras a reference whenever an action is being used. Instead, one of the available tags should be used such as:Tags are used alongside semantic versioning to provide a stable experience: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-actions#versioning-your-action
The master branch can abruptly change without notice during development which can cause workflows to unexpectedly fail. If you want to avoid unexpected changes or failures, you should use a tag when referring to a specific version of an action. Tags are added to stable versions that have undergone significant testing and should not change.
The
v2versions ofdownload-artifactandupload-artifactare currently in development. Expect changes to start showing up in thev2-previewbranch. These new changes will eventually be merged intomaster(we will communicate about this in the future) and that will have the potential to break your workflows if you are using@masterso you will have to react by updating your YAML to use a tag.Our telemetry indicates a significant amount of users are using
@master. Good practice for all actions is to use a tag instead of referencing@master.The text was updated successfully, but these errors were encountered: