-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection errors with v2 #71
Comments
hmmm.. so I stumbled on this issue early on during the A large chunk of users are pinned to |
This issue affect not only large files. I have a 2KB file failed uploading. log
And upload-artifacts should exit with a non-zero exit code, while its current behavior is ignore and continue. |
That happened in v1 too, but I agree. I have to always manually check the logs to make sure the upload was successful and it would be great not to have to do that. |
For those that users that hit this issue, could you please provide a link to the run that was faulty? (if your repo is public of course). I'm basically trying to see if there is some pattern between when the first I don't think the issue is related to the type of file (large or small upload), but rather how long the upload is taking |
@konradpabjan My run log is available at https://github.com/zhangyoufu/alpine/runs/629165891. Is there any simultaneous connection limit, QPS limit on Azure Artifacts side? |
I just hit this bug. The log is available at https://github.com/grpc/grpc-node/runs/654464810 |
I think it might be related to this... actions/cache#298 The retry should work, however all 4 retries fail with the same error, so I suspect this could be an issue with the readstream. An |
Just bumped into this myself (in private repo though). In addition to this being a really odd error, it would be ideal if this failed the job also. Downloading the artifact does fail, so at least my whole deploy process didn't try to push something out to production! |
This should 🤞 be fixed with the PR that was just merged. I'll be updating the |
@konradpabjan I'm not sure if this is the same issue, but we've been seeing a lot of 500 errors when Unfortunately it's in a private repo, so I don't know how best to share an example. Any help would be great! I can also create a separate issue for this if you don't think it's related. For reference, we are depending on
|
Thanks for the notice @agrobbin This looks to be another problem. Could you open up another issue? We can track it there. |
@konradpabjan done in #84! |
I hit it An error has been caught http-client index 1, retrying the upload
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:201:27) {
errno: 'ECONNRESET',
code: 'ECONNRESET',
syscall: 'read'
}
Exponential backoff for retry #1. Waiting for 5077.766121471924 milliseconds before continuing the upload at offset 0
Finished backoff for retry #1, continuing with upload
Total file count: 8402 ---- Processed file #5062 (60.2%)
Total file count: 8402 ---- Processed file #5215 (62.0%)
Total file count: 8402 ---- Processed file #5353 (63.7%)
Total file count: 8402 ---- Processed file #5499 (65.4%)
Total file count: 8402 ---- Processed file #5640 (67.1%)
Total file count: 8402 ---- Processed file #5789 (68.9%)
Total file count: 8402 ---- Processed file #5933 (70.6%)
An error has been caught http-client index 0, retrying the upload
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:201:27) {
errno: 'ECONNRESET',
code: 'ECONNRESET',
syscall: 'read'
}
Exponential backoff for retry #1. Waiting for 6224.009953806136 milliseconds before continuing the upload at offset 0
Finished backoff for retry #1, continuing with upload
Total file count: 8402 ---- Processed file #5986 (71.2%)
Total file count: 8402 ---- Processed file #6126 (72.9%)
Total file count: 8402 ---- Processed file #6268 (74.6%)
Total file count: 8402 ---- Processed file #6412 (76.3%)
Total file count: 8402 ---- Processed file #6549 (77.9%) The repo is private but this is the job: create_artifact:
name: Create Artifact
runs-on: ubuntu-20.04
needs: [tests_phpunit]
steps:
- uses: actions/checkout@v2
- name: Switch default PHP Version to 7.4
run: sudo update-alternatives --set php /usr/bin/php7.4
- name: composer install
run: composer install --no-interaction --no-progress
- name: yarn install
run: yarn install
- name: yarn build
run: yarn build
- name: Create development artifact
uses: actions/upload-artifact@v2
with:
name: development-code
path: |
assets
bin
config
public
src
templates
translations
vendor
.env
.env.test
composer.json
composer.lock During a second run I noticed this one: An error has been caught http-client index 1, retrying the upload
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:201:27) {
errno: 'ECONNRESET',
code: 'ECONNRESET',
syscall: 'read'
}
Exponential backoff for retry #1. Waiting for 4936.179816716808 milliseconds before continuing the upload at offset 0
An error has been caught http-client index 0, retrying the upload
Error: Client has already been disposed.
at HttpClient.request (/home/runner/work/_actions/actions/upload-artifact/v2/dist/index.js:5694:19)
at HttpClient.sendStream (/home/runner/work/_actions/actions/upload-artifact/v2/dist/index.js:5655:21)
at UploadHttpClient.<anonymous> (/home/runner/work/_actions/actions/upload-artifact/v2/dist/index.js:7104:37)
at Generator.next (<anonymous>)
at /home/runner/work/_actions/actions/upload-artifact/v2/dist/index.js:6834:71
at new Promise (<anonymous>)
at module.exports.608.__awaiter (/home/runner/work/_actions/actions/upload-artifact/v2/dist/index.js:6830:12)
at uploadChunkRequest (/home/runner/work/_actions/actions/upload-artifact/v2/dist/index.js:7102:46)
at UploadHttpClient.<anonymous> (/home/runner/work/_actions/actions/upload-artifact/v2/dist/index.js:7139:38)
at Generator.next (<anonymous>) |
|
Hi, @AMartinNo1 Please change the uses: actions/upload-artifact@v1 I believe it would work for you as well. I was getting the same issue but changing the actions/upload-artifact@v1 and now it is working fine for me. Let us know if any other issue. |
I will keep that in mind. For now I stopped using the artefact. |
Just ran into this. Here are my logs: |
This error doesn't appear to have been fixed. It eventually works after about 10 retries. Task:
Error:
|
…fort to avoid transient failures, considering actions/upload-artifact#71
EDIT: It is Github Itself experiencing an issue. Apologies for raising any alarms... I have just bumped into this, so while the re-try is ticking to 5 and the minutes past 15, I thought I would post it here for posterity. This is occurring after a successful document build to my https://github.com/citkane/typedoc-theme-yaf/actions/runs/3960780756/jobs/6785378185 |
The text was updated successfully, but these errors were encountered: