Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version_bump.yml files to use composite GitHub Actions #98

Merged
merged 7 commits into from
Mar 23, 2022

Conversation

Jaybsoni
Copy link
Contributor

Using a new composite GitHub Action to complete version bumps

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #98 (5781369) into master (3df6f5a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          498       498           
=========================================
  Hits           498       498           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df6f5a...5781369. Read the comment docs.

@Jaybsoni Jaybsoni changed the title Updated pre_release_version_bump.yml file Updated version_bump.yml files to use composite GitHub Actions Mar 22, 2022
@Jaybsoni Jaybsoni mentioned this pull request Mar 22, 2022
@Jaybsoni
Copy link
Contributor Author

[sc-16345]

@Jaybsoni Jaybsoni requested a review from antalszava March 22, 2022 19:49
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking awesome! 🎉 😍 Great one with this.

- name: Install Python
uses: actions/setup-python@v2
- name: Run post-release version bump
uses: PennyLaneAI/automation/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if as per our chat, we should pin to master here instead of v1.0. Also found this (though may not be relevant anymore):
actions/upload-artifact#41

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I remember reading a similar warning in their docs. Maybe it's better to leave it as is for now? If anything, we can create a new repo and remove the current one, transfer the action to the new one and tag it at v0.1 or v0.1.0 to allow for future tag changes as new actions are added and tested.

--version_path "./pennylane_sf/_version.py"
--changelog_path "./.github/CHANGELOG.md" --post_release
version_path: "./pennylane_sf/_version.py"
changelog_path: "./.github/CHANGELOG.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's great we can input this! 😮 💯

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! we can set inputs and extract outputs as well! In this way a composite action can be run, and then outputs extracted and passed to local actions ! Its a very flexible framework!

@Jaybsoni Jaybsoni mentioned this pull request Mar 23, 2022
@Jaybsoni Jaybsoni merged commit b9ddad3 into master Mar 23, 2022
@Jaybsoni Jaybsoni deleted the remote_vb branch March 23, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants