-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated version_bump.yml files to use composite GitHub Actions #98
Conversation
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 498 498
=========================================
Hits 498 498 Continue to review full report at Codecov.
|
[sc-16345] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking awesome! 🎉 😍 Great one with this.
- name: Install Python | ||
uses: actions/setup-python@v2 | ||
- name: Run post-release version bump | ||
uses: PennyLaneAI/automation/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if as per our chat, we should pin to master
here instead of v1.0
. Also found this (though may not be relevant anymore):
actions/upload-artifact#41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I remember reading a similar warning in their docs. Maybe it's better to leave it as is for now? If anything, we can create a new repo and remove the current one, transfer the action to the new one and tag it at v0.1 or v0.1.0 to allow for future tag changes as new actions are added and tested.
--version_path "./pennylane_sf/_version.py" | ||
--changelog_path "./.github/CHANGELOG.md" --post_release | ||
version_path: "./pennylane_sf/_version.py" | ||
changelog_path: "./.github/CHANGELOG.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's great we can input this! 😮 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! we can set inputs and extract outputs as well! In this way a composite action can be run, and then outputs extracted and passed to local actions ! Its a very flexible framework!
Using a new composite GitHub Action to complete version bumps