Updated version_bump.yml files to use composite GitHub Actions #98
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,21 +12,12 @@ jobs: | |
| - name: Clone repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Run post-release version bump | ||
| uses: PennyLaneAI/automation/[email protected] | ||
| with: | ||
| version_path: "./pennylane_sf/_version.py" | ||
| changelog_path: "./.github/CHANGELOG.md" | ||
|
There was a problem hiding this comment. Oh, it's great we can input this! 😮 💯 There was a problem hiding this comment. Yes! we can set inputs and extract outputs as well! In this way a composite action can be run, and then outputs extracted and passed to local actions ! Its a very flexible framework! |
||
| release_status: "post_release" | ||
|
|
||
| - name: Create Pull Request | ||
| uses: peter-evans/create-pull-request@v3 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,22 +10,13 @@ jobs: | |
| steps: | ||
| - name: Clone repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Run pre-release version bump | ||
| uses: PennyLaneAI/automation/[email protected] | ||
| with: | ||
| version_path: "./pennylane_sf/_version.py" | ||
| changelog_path: "./.github/CHANGELOG.md" | ||
| release_status: "pre_release" | ||
|
|
||
| - name: Create Pull Request | ||
| uses: peter-evans/create-pull-request@v3 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if as per our chat, we should pin to
masterhere instead ofv1.0. Also found this (though may not be relevant anymore):actions/upload-artifact#41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I remember reading a similar warning in their docs. Maybe it's better to leave it as is for now? If anything, we can create a new repo and remove the current one, transfer the action to the new one and tag it at v0.1 or v0.1.0 to allow for future tag changes as new actions are added and tested.