-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup command, workflow, Issue retrieval for review step #915
Conversation
5f8e870
to
7fbdeb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
- name: Automated application review | ||
run: | | ||
chmod +x ./processor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH retains permissions in artifact uploading, so if it was uploaded with execute, it still should be here. dsaltares/fetch-gh-release-asset
might not respect the permissions though.
/dev/web/developer.1password.com/-/issues/1065
Summary
We are working on improvements to the 1Password for Open Source program. This PR sets up some of the foundation for automated reviews.
What's changed?
review-application
workflow that is triggered whenever an issue with the label "application" is opened or edited. This workflow will download the latestprocessor
script, calling itsreview
command and passing along relevant environment variables.GitHub
struct that can be used to instantiate the GitHub API client with the provided env vars.Reviewer
struct that is called whenever./processor review
is called. Right now all this does is retrieve an issue and print it. The next step will be to validate issue details.Of note... I'm realizing that it might be nice to move to a proper CLI package like Cobra, but for now let's keep it simple.
Testing
You can test out the processor command like so:
There is currently only one test issue available, and it will just print its contents for now.