new rule: ARIA required ID references exist #2041

WilcoFiers · 2023-03-30T11:29:08Z

This PR is related to #2012, where we took the requirement for ID references to exist in the same tree out. Separating these tests into their own rule allows us to be a little more precise, and as the rules format requires for this to be atomic.

Need for Call for Review: 1 week (because this isn't actually new)

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

_rules/aria-required-id-references-in6db8.md

carlosapaduarte · 2023-03-31T17:43:23Z

_rules/aria-required-id-references-in6db8.md

+
+#### Inapplicable Example 2
+
+The `aria-controls` attribute is not required on a `button`.


The fact that the aria-controls is not required is not considered by the accessibility. What makes this inapplicable is that the element is not a combobox or a scrollbar.

_rules/aria-required-id-references-in6db8.md

Co-authored-by: Carlos Duarte <[email protected]>

Resolved

Jym77

Looks good.
With an Applicability very different from the sister rule, I think the split does make sense 👍
Small question around whether the rule should target the element or the attribute.

_rules/aria-required-id-references-in6db8.md

Co-authored-by: Jean-Yves Moyen <[email protected]>

Updated, please check again

_rules/aria-required-id-references-in6db8.md

tombrunet · 2023-05-18T19:51:00Z

_rules/aria-required-id-references-in6db8.md

+#### Inapplicable Example 3
+
+The `button` does not have an `aria-controls` attribute.
+
+```html
+<button>Open the modal</button>
+```


It feels odd to have this after Inapplicable 2, but without more description. It also does not have a semantic role of scrollbar nor combobox, so it's inapplicable for the same reason.

Jym77

Suggestions to polish a bit the examples descriptions to better match the wording of the rule. This is not blocking, though.

_rules/aria-required-id-references-in6db8.md

Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

MelSumner · 2023-06-16T12:57:44Z

This is great! I like the separation.

AndyAtTV

Failed Example 3 uses attribute shadowrootmode for the shadow code. But this isn't in the HTML5 spec, it is a webkit specific attribute. So I'd suggest using javascript to add this.

_rules/aria-required-id-references-in6db8.md

WilcoFiers · 2023-06-22T15:10:10Z

@AndyAtTV Thanks for bringing that up! I completely forgot to check the spec about that. I've changed it to use shadow DOM through a script tag.

WilcoFiers · 2023-06-22T15:17:53Z

I dismissed all reviews. To rereviewers, I think this is an editorial change so it doesn't need another call for review. Just 3 approvals.

MelSumner · 2023-06-26T21:18:58Z

Maybe silly question about shadow DOM - should it pass since it still wouldn't be usable for the end user?

I do see the value of checking that it exists, but I wonder about this.

carlosapaduarte

Incorrect element mentioned in a test case description

_rules/aria-required-id-references-in6db8.md

Co-authored-by: Carlos Duarte <[email protected]>

WilcoFiers · 2023-07-07T12:38:11Z

@MelSumner The shadow DOM example should fail, as it create an accessibility issue. I'm not sure I understood your comment though. Do you want to elaborate?

* new rule: ARIA required ID references exist * Address review comments Co-authored-by: Carlos Duarte <[email protected]> * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Apply suggestions from code review Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/aria-required-id-references-in6db8.md * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> --------- Co-authored-by: Carlos Duarte <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Tom Brunet <[email protected]>

…2125) * Update programmatically-determined-link-context.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update programmatically-determined-link-context.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Create modal-dialog * Rename modal-dialog to modal-dialog.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Apply suggestions from code review Co-authored-by: Dan Tripp <[email protected]> * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update and rename modal-dialog.md to inert.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update spelling-ignore.yml * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update inert.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Dan Tripp <[email protected]> * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update inert.md * Apply suggestions from code review Co-authored-by: Wilco Fiers <[email protected]> * AGWG Updates (#2067) * Add (alt="") for clarity on empty alt * Resolve focus visible feedback * Tweak contrast rules * Tweak page title descriptive * Fix tests * Apply suggestions from code review Co-authored-by: Trevor R. Bostic <[email protected]> --------- Co-authored-by: Trevor R. Bostic <[email protected]> * [cae760] Frame has non-empty accessible name (#2034) * First pass in response to Feb 16 TF meeting * typo * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Move note about frame to background * Set height for frame * Test wants alphabetical contributors * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Move note to background --------- Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Updating glossary definition. (#2069) * Bump yaml and zx (#2056) * Bump yaml and zx Bumps [yaml](https://github.com/eemeli/yaml) to 2.2.2 and updates ancestor dependency [zx](https://github.com/google/zx). These dependencies need to be updated together. Updates `yaml` from 1.10.2 to 2.2.2 - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v1.10.2...v2.2.2) Updates `zx` from 5.3.0 to 7.2.1 - [Release notes](https://github.com/google/zx/releases) - [Commits](google/zx@5.3.0...7.2.1) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect - dependency-name: zx dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Trigger CLA? --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <[email protected]> * new rule: ARIA required ID references exist (#2041) * new rule: ARIA required ID references exist * Address review comments Co-authored-by: Carlos Duarte <[email protected]> * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Apply suggestions from code review Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/aria-required-id-references-in6db8.md * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> --------- Co-authored-by: Carlos Duarte <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Tom Brunet <[email protected]> * scrollable element: clarify the title (#2083) * UpdateTableHeaderRule (#2074) * UpdateTableHeaderRule * Update table-header-cell-has-assigned-cells-d0f69e.md * trigger test * Update _rules/table-header-cell-has-assigned-cells-d0f69e.md Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Adds apostrophe to mark the possessive form (#2080) Co-authored-by: Wilco Fiers <[email protected]> * Focus visible rule: Fix typo (#2082) * Contrast rules: Tweak background text (#2090) * Tweak name / description of Scrollable element keyboard (#2092) * Deprecate HTML page lang and xml:lang attributes have matching values (#2086) * Deprecate HTML page lang and xml:lang attributes have matching values * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> --------- Co-authored-by: Carlos Duarte <[email protected]> * Rephrase Applicability (#2079) * Rename file (#2078) * Move secondary requirement texts out of the background (#2060) * Move secondary requirement texts out of the background * Apply suggestions from code review * fix test * Fix failing test * Secondary reqs on ARIA rules * Update all secondary requirements * Typos * Fix failing tests * Update _rules/link-non-empty-accessible-name-c487ae.md Co-authored-by: Trevor R. Bostic <[email protected]> * Tweaked the language some more * Update rule design info for secondary requirements * Fix tests * Apply suggestions from code review Co-authored-by: Kathy Eng <[email protected]> * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Trevor R. Bostic <[email protected]> Co-authored-by: Kathy Eng <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * fix test on secondary requirements (#2102) * fix test on secondary requirements * More assertions * Update _rules/aria-required-id-references-in6db8.md Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Jean-Yves Moyen <[email protected]> * Update dependencies (including act-tools) (#2103) * fix test-assets not getting built right (#2104) * Update element-lang-valid-de46e4.md (#2100) Co-authored-by: Jean-Yves Moyen <[email protected]> * fix the approve-rule action (#2105) * Remove outdated accsupport note (#2111) * "Element with lang attribute has valid language tag" [de46e4]: Updated Failed Examples 4 and 5 to reflect Applicability (#2094) * Update element-lang-valid-de46e4.md Updated Failed examples 4 and 5 to reflect applicability * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/element-lang-valid-de46e4.md Co-authored-by: Dan Tripp <[email protected]> --------- Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Dan Tripp <[email protected]> Co-authored-by: Carlos Duarte <[email protected]> * Text spacing rewrite (#1923) * Add new letter-spacing rule and deprecate old one * Add new word-spacing rule and deprecate old one * Clean up assumptions * Clean up * Clean up * Add new line-height rule and deprecate old one * Replace old letter spacing version rather than deprecating it * Replace old line height version rather than deprecating it * Replace old word spacing version rather than deprecating it * Target text nodes * Improve background note * Apply suggestion from review * Clean up * Target text nodes rather than their parents * Target text nodes rather than their parents * Add missing reference * Update example * Apply to parent of text nodes, not text nodes * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> * Typos Co-authored-by: Carlos Duarte <[email protected]> * Typos --------- Co-authored-by: Carlos Duarte <[email protected]> * "Meta viewport allows for zoom" (b4f0c3): Explicit meaning of 'has' (#1994) * Explicit meaning of 'has' * Improve expectation and examples * Typo * Improve algorithm description Co-authored-by: Carlos Duarte <[email protected]> * Rephrase expectations * Streamline Applicability * Typo * Simplify expectations --------- Co-authored-by: Carlos Duarte <[email protected]> * Map Empty-heading rule to ARIA instead of WCAG (#2120) Co-authored-by: Jean-Yves Moyen <[email protected]> * Deprecate 4.1.1 rules (#2117) Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: giacomo-petri <[email protected]> Co-authored-by: Carlos Duarte <[email protected]> Co-authored-by: Dan Tripp <[email protected]> Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Trevor R. Bostic <[email protected]> Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HelenBurge <[email protected]> Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Daniel Montalvo <[email protected]> Co-authored-by: Kathy Eng <[email protected]>

new rule: ARIA required ID references exist

d4799c6

WilcoFiers mentioned this pull request Mar 30, 2023

ARIA state or property: various editorial improvements #2012

Merged

WilcoFiers requested review from ajanec01, carlosapaduarte, Jym77 and tombrunet March 30, 2023 14:22

carlosapaduarte previously requested changes Mar 31, 2023

View reviewed changes

WilcoFiers commented Apr 6, 2023

View reviewed changes

_rules/aria-required-id-references-in6db8.md Outdated Show resolved Hide resolved

WilcoFiers commented Apr 6, 2023

View reviewed changes

_rules/aria-required-id-references-in6db8.md Show resolved Hide resolved

Address review comments

1b4f97e

Co-authored-by: Carlos Duarte <[email protected]>

WilcoFiers requested a review from carlosapaduarte April 6, 2023 11:54

Jym77 previously requested changes Apr 13, 2023

View reviewed changes

_rules/aria-required-id-references-in6db8.md Outdated Show resolved Hide resolved

_rules/aria-required-id-references-in6db8.md Outdated Show resolved Hide resolved

Apply suggestions from code review

d735439

Co-authored-by: Jean-Yves Moyen <[email protected]>

WilcoFiers requested a review from Jym77 May 11, 2023 12:46

Merge branch 'develop' into aria-required-id-refs

d0d2525

WilcoFiers requested review from tbostic32 and daniel-montalvo May 18, 2023 13:16

tombrunet reviewed May 18, 2023

View reviewed changes

Jym77 approved these changes May 25, 2023

View reviewed changes

_rules/aria-required-id-references-in6db8.md Outdated Show resolved Hide resolved

_rules/aria-required-id-references-in6db8.md Outdated Show resolved Hide resolved

_rules/aria-required-id-references-in6db8.md Outdated Show resolved Hide resolved

daniel-montalvo approved these changes May 25, 2023

View reviewed changes

Apply suggestions from code review

436bb56

Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

WilcoFiers requested a review from tombrunet June 15, 2023 12:45

tombrunet approved these changes Jun 15, 2023

View reviewed changes

WilcoFiers added Review call 2 weeks Call for review for new rules and big changes Review Call 1 week Call for review for small changes and removed Review call 2 weeks Call for review for new rules and big changes labels Jun 16, 2023

carlosapaduarte approved these changes Jun 16, 2023

View reviewed changes

AndyAtTV reviewed Jun 16, 2023

View reviewed changes

WilcoFiers commented Jun 22, 2023

View reviewed changes

_rules/aria-required-id-references-in6db8.md Outdated Show resolved Hide resolved

Update _rules/aria-required-id-references-in6db8.md

63e7829

WilcoFiers requested review from AndyAtTV, carlosapaduarte, tombrunet, Jym77 and daniel-montalvo June 22, 2023 15:10

Jym77 approved these changes Jun 23, 2023

View reviewed changes

AndyAtTV approved these changes Jun 23, 2023

View reviewed changes

carlosapaduarte requested changes Jul 6, 2023

View reviewed changes

_rules/aria-required-id-references-in6db8.md Outdated Show resolved Hide resolved

Apply suggestions from code review

3488162

Co-authored-by: Carlos Duarte <[email protected]>

WilcoFiers requested a review from carlosapaduarte July 7, 2023 12:38

carlosapaduarte approved these changes Jul 7, 2023

View reviewed changes

Merge branch 'develop' into aria-required-id-refs

9878e12

WilcoFiers merged commit 46f34ac into develop Jul 10, 2023

WilcoFiers deleted the aria-required-id-refs branch July 10, 2023 10:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new rule: ARIA required ID references exist #2041

new rule: ARIA required ID references exist #2041

WilcoFiers commented Mar 30, 2023

carlosapaduarte Mar 31, 2023

Jym77 left a comment

tombrunet May 18, 2023

Jym77 left a comment

MelSumner commented Jun 16, 2023

AndyAtTV left a comment

WilcoFiers commented Jun 22, 2023

WilcoFiers commented Jun 22, 2023

MelSumner commented Jun 26, 2023

carlosapaduarte left a comment

WilcoFiers commented Jul 7, 2023


		#### Inapplicable Example 2

		The `aria-controls` attribute is not required on a `button`.

new rule: ARIA required ID references exist #2041

new rule: ARIA required ID references exist #2041

Conversation

WilcoFiers commented Mar 30, 2023

How to Review And Approve

carlosapaduarte Mar 31, 2023

Choose a reason for hiding this comment

Jym77 left a comment

Choose a reason for hiding this comment

tombrunet May 18, 2023

Choose a reason for hiding this comment

Jym77 left a comment

Choose a reason for hiding this comment

MelSumner commented Jun 16, 2023

AndyAtTV left a comment

Choose a reason for hiding this comment

WilcoFiers commented Jun 22, 2023

WilcoFiers commented Jun 22, 2023

MelSumner commented Jun 26, 2023

carlosapaduarte left a comment

Choose a reason for hiding this comment

WilcoFiers commented Jul 7, 2023