[cae760] Frame has non-empty accessible name #2034

tombrunet · 2023-02-16T16:34:36Z

Adjustments to the rule based on conversation of task force conversations (Feb 16, 2023).

Note regarding the two above issues. There is no perfect answer here since the browser behaviors are all different. However, the approach in this PR was to ignore cases where it's clear that the author attempts to remove the iframe from the sequential focus navigation.

Need for Call for Review:
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>

Pull Request Etiquette

When creating PR:

Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR.
Add label to indicate if it's a Rule, Definition or Chore.
Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

_rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <[email protected]>

Jym77

Agreeing with Wilco's comment.
It also seems that you need to add yourself as an contributor, iirc this is done by modifying package.json. I suggest you do that bit in a separate PR (can be merged with one Approval), since it shouldn't be blocked by this PR (in case it takes longer than expected).

Co-authored-by: Wilco Fiers <[email protected]>

tombrunet · 2023-04-11T19:16:47Z

@Jym77 #2048 for adding contributor

Changes were done

Jym77

Looks pretty good. A few polishing comments.

_rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Jean-Yves Moyen <[email protected]>

tombrunet · 2023-05-08T19:06:40Z

@Jym77 I think I have everything you suggested resolved, and I re-requested review, but it still shows a change requested, not sure why. Can you re-review? Thanks.

Jym77 · 2023-05-09T07:00:05Z

@Jym77 I think I have everything you suggested resolved, and I re-requested review, but it still shows a change requested, not sure why. Can you re-review? Thanks.

Yes, the review needs to be dimissed… (Bottom box, "change requested" dropdown, dots menu on the review to dismiss). I've done it.

Changes done.

Jym77 · 2023-05-25T09:21:39Z

@tombrunet This looks like this is good to go in Call for Review 🎉
Do you want me to do it?

tombrunet · 2023-06-06T16:50:43Z

@Jym77 I was out on vacation, but it's sent now.

* First pass in response to Feb 16 TF meeting * typo * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Move note about frame to background * Set height for frame * Test wants alphabetical contributors * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Move note to background --------- Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

…2125) * Update programmatically-determined-link-context.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update programmatically-determined-link-context.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Create modal-dialog * Rename modal-dialog to modal-dialog.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Apply suggestions from code review Co-authored-by: Dan Tripp <[email protected]> * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update and rename modal-dialog.md to inert.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update spelling-ignore.yml * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update inert.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Dan Tripp <[email protected]> * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update inert.md * Apply suggestions from code review Co-authored-by: Wilco Fiers <[email protected]> * AGWG Updates (#2067) * Add (alt="") for clarity on empty alt * Resolve focus visible feedback * Tweak contrast rules * Tweak page title descriptive * Fix tests * Apply suggestions from code review Co-authored-by: Trevor R. Bostic <[email protected]> --------- Co-authored-by: Trevor R. Bostic <[email protected]> * [cae760] Frame has non-empty accessible name (#2034) * First pass in response to Feb 16 TF meeting * typo * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Move note about frame to background * Set height for frame * Test wants alphabetical contributors * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Move note to background --------- Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Updating glossary definition. (#2069) * Bump yaml and zx (#2056) * Bump yaml and zx Bumps [yaml](https://github.com/eemeli/yaml) to 2.2.2 and updates ancestor dependency [zx](https://github.com/google/zx). These dependencies need to be updated together. Updates `yaml` from 1.10.2 to 2.2.2 - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v1.10.2...v2.2.2) Updates `zx` from 5.3.0 to 7.2.1 - [Release notes](https://github.com/google/zx/releases) - [Commits](google/zx@5.3.0...7.2.1) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect - dependency-name: zx dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Trigger CLA? --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <[email protected]> * new rule: ARIA required ID references exist (#2041) * new rule: ARIA required ID references exist * Address review comments Co-authored-by: Carlos Duarte <[email protected]> * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Apply suggestions from code review Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/aria-required-id-references-in6db8.md * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> --------- Co-authored-by: Carlos Duarte <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Tom Brunet <[email protected]> * scrollable element: clarify the title (#2083) * UpdateTableHeaderRule (#2074) * UpdateTableHeaderRule * Update table-header-cell-has-assigned-cells-d0f69e.md * trigger test * Update _rules/table-header-cell-has-assigned-cells-d0f69e.md Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Adds apostrophe to mark the possessive form (#2080) Co-authored-by: Wilco Fiers <[email protected]> * Focus visible rule: Fix typo (#2082) * Contrast rules: Tweak background text (#2090) * Tweak name / description of Scrollable element keyboard (#2092) * Deprecate HTML page lang and xml:lang attributes have matching values (#2086) * Deprecate HTML page lang and xml:lang attributes have matching values * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> --------- Co-authored-by: Carlos Duarte <[email protected]> * Rephrase Applicability (#2079) * Rename file (#2078) * Move secondary requirement texts out of the background (#2060) * Move secondary requirement texts out of the background * Apply suggestions from code review * fix test * Fix failing test * Secondary reqs on ARIA rules * Update all secondary requirements * Typos * Fix failing tests * Update _rules/link-non-empty-accessible-name-c487ae.md Co-authored-by: Trevor R. Bostic <[email protected]> * Tweaked the language some more * Update rule design info for secondary requirements * Fix tests * Apply suggestions from code review Co-authored-by: Kathy Eng <[email protected]> * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Trevor R. Bostic <[email protected]> Co-authored-by: Kathy Eng <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * fix test on secondary requirements (#2102) * fix test on secondary requirements * More assertions * Update _rules/aria-required-id-references-in6db8.md Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Jean-Yves Moyen <[email protected]> * Update dependencies (including act-tools) (#2103) * fix test-assets not getting built right (#2104) * Update element-lang-valid-de46e4.md (#2100) Co-authored-by: Jean-Yves Moyen <[email protected]> * fix the approve-rule action (#2105) * Remove outdated accsupport note (#2111) * "Element with lang attribute has valid language tag" [de46e4]: Updated Failed Examples 4 and 5 to reflect Applicability (#2094) * Update element-lang-valid-de46e4.md Updated Failed examples 4 and 5 to reflect applicability * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/element-lang-valid-de46e4.md Co-authored-by: Dan Tripp <[email protected]> --------- Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Dan Tripp <[email protected]> Co-authored-by: Carlos Duarte <[email protected]> * Text spacing rewrite (#1923) * Add new letter-spacing rule and deprecate old one * Add new word-spacing rule and deprecate old one * Clean up assumptions * Clean up * Clean up * Add new line-height rule and deprecate old one * Replace old letter spacing version rather than deprecating it * Replace old line height version rather than deprecating it * Replace old word spacing version rather than deprecating it * Target text nodes * Improve background note * Apply suggestion from review * Clean up * Target text nodes rather than their parents * Target text nodes rather than their parents * Add missing reference * Update example * Apply to parent of text nodes, not text nodes * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> * Typos Co-authored-by: Carlos Duarte <[email protected]> * Typos --------- Co-authored-by: Carlos Duarte <[email protected]> * "Meta viewport allows for zoom" (b4f0c3): Explicit meaning of 'has' (#1994) * Explicit meaning of 'has' * Improve expectation and examples * Typo * Improve algorithm description Co-authored-by: Carlos Duarte <[email protected]> * Rephrase expectations * Streamline Applicability * Typo * Simplify expectations --------- Co-authored-by: Carlos Duarte <[email protected]> * Map Empty-heading rule to ARIA instead of WCAG (#2120) Co-authored-by: Jean-Yves Moyen <[email protected]> * Deprecate 4.1.1 rules (#2117) Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: giacomo-petri <[email protected]> Co-authored-by: Carlos Duarte <[email protected]> Co-authored-by: Dan Tripp <[email protected]> Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Trevor R. Bostic <[email protected]> Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HelenBurge <[email protected]> Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Daniel Montalvo <[email protected]> Co-authored-by: Kathy Eng <[email protected]>

First pass in response to Feb 16 TF meeting

1aa4f11

tombrunet added the Rule Update Use this label for an existing rule that is being updated label Feb 16, 2023

tombrunet requested review from WilcoFiers and kengdoj February 16, 2023 16:34

tombrunet self-assigned this Feb 16, 2023

typo

7a38b29

carlosapaduarte approved these changes Feb 17, 2023

View reviewed changes

WilcoFiers previously requested changes Feb 20, 2023

View reviewed changes

Update _rules/iframe-non-empty-accessible-name-cae760.md

1e1faf1

Co-authored-by: Wilco Fiers <[email protected]>

Jym77 requested changes Feb 23, 2023

View reviewed changes

tombrunet and others added 7 commits April 11, 2023 13:54

Update _rules/iframe-non-empty-accessible-name-cae760.md

4cd91cf

Co-authored-by: Wilco Fiers <[email protected]>

Update _rules/iframe-non-empty-accessible-name-cae760.md

74aff91

Co-authored-by: Wilco Fiers <[email protected]>

Update _rules/iframe-non-empty-accessible-name-cae760.md

34cab69

Co-authored-by: Wilco Fiers <[email protected]>

Update _rules/iframe-non-empty-accessible-name-cae760.md

d2fc330

Co-authored-by: Wilco Fiers <[email protected]>

Merge branch 'develop' into cae760-frame-name-2023-02

4c813ec

Move note about frame to background

7abcc0d

Set height for frame

ef3edde

Test wants alphabetical contributors

e336e16

tombrunet requested review from WilcoFiers, Jym77 and carlosapaduarte April 11, 2023 19:19

Jym77 previously requested changes Apr 13, 2023

View reviewed changes

_rules/iframe-non-empty-accessible-name-cae760.md Outdated Show resolved Hide resolved

_rules/iframe-non-empty-accessible-name-cae760.md Outdated Show resolved Hide resolved

_rules/iframe-non-empty-accessible-name-cae760.md Outdated Show resolved Hide resolved

tombrunet and others added 5 commits April 13, 2023 08:16

Update _rules/iframe-non-empty-accessible-name-cae760.md

928d878

Co-authored-by: Jean-Yves Moyen <[email protected]>

Update _rules/iframe-non-empty-accessible-name-cae760.md

8c6f6b4

Co-authored-by: Jean-Yves Moyen <[email protected]>

Merge branch 'develop' into cae760-frame-name-2023-02

8383d15

Update _rules/iframe-non-empty-accessible-name-cae760.md

d67cb8a

Co-authored-by: Jean-Yves Moyen <[email protected]>

Move note to background

0d31169

tombrunet requested a review from Jym77 May 4, 2023 17:38

WilcoFiers approved these changes May 11, 2023

View reviewed changes

WilcoFiers requested a review from HelenBurge May 18, 2023 13:16

HelenBurge approved these changes May 18, 2023

View reviewed changes

kengdoj approved these changes May 22, 2023

View reviewed changes

Jym77 approved these changes May 25, 2023

View reviewed changes

Merge branch 'develop' into cae760-frame-name-2023-02

1f8cbb7

Merge branch 'develop' into cae760-frame-name-2023-02

0eea037

bruce-usab approved these changes Jun 6, 2023

View reviewed changes

carlosapaduarte approved these changes Jun 6, 2023

View reviewed changes

Merge branch 'develop' into cae760-frame-name-2023-02

61b7a92

WilcoFiers merged commit e11aaaa into act-rules:develop Jun 15, 2023

Jym77 mentioned this pull request Jun 29, 2023

SIA-R13: make inapplicable to <iframe> that are marked as decorative. Siteimprove/alfa#1445

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cae760] Frame has non-empty accessible name #2034

[cae760] Frame has non-empty accessible name #2034

tombrunet commented Feb 16, 2023 •

edited

Loading

Jym77 left a comment

tombrunet commented Apr 11, 2023

Jym77 left a comment

tombrunet commented May 8, 2023

Jym77 commented May 9, 2023

Jym77 commented May 25, 2023

tombrunet commented Jun 6, 2023

[cae760] Frame has non-empty accessible name #2034

[cae760] Frame has non-empty accessible name #2034

Conversation

tombrunet commented Feb 16, 2023 • edited Loading

Pull Request Etiquette

When creating PR:

After creating PR:

When merging a PR:

How to Review And Approve

Jym77 left a comment

Choose a reason for hiding this comment

tombrunet commented Apr 11, 2023

Jym77 left a comment

Choose a reason for hiding this comment

tombrunet commented May 8, 2023

Jym77 commented May 9, 2023

Jym77 commented May 25, 2023

tombrunet commented Jun 6, 2023

tombrunet commented Feb 16, 2023 •

edited

Loading