AGWG Updates #2067

WilcoFiers · 2023-05-25T11:24:18Z

Resolve feedback from this old AGWG survey:

https://www.w3.org/2002/09/wbs/35422/act-dec-2022/results

Need for Call for Review: none, editorial

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

_rules/html-page-title-descriptive-c4a8a4.md

_rules/image-button-non-empty-accessible-name-59796f.md

_rules/image-non-empty-accessible-name-23a2a8.md

kengdoj

just Trevor's suggestion

_rules/html-page-title-descriptive-c4a8a4.md

_rules/image-button-non-empty-accessible-name-59796f.md

Co-authored-by: Trevor R. Bostic <[email protected]>

Updated

* Add (alt="") for clarity on empty alt * Resolve focus visible feedback * Tweak contrast rules * Tweak page title descriptive * Fix tests * Apply suggestions from code review Co-authored-by: Trevor R. Bostic <[email protected]> --------- Co-authored-by: Trevor R. Bostic <[email protected]>

…2125) * Update programmatically-determined-link-context.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update programmatically-determined-link-context.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Create modal-dialog * Rename modal-dialog to modal-dialog.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Apply suggestions from code review Co-authored-by: Dan Tripp <[email protected]> * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update and rename modal-dialog.md to inert.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update spelling-ignore.yml * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update inert.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Dan Tripp <[email protected]> * Update iframe-not-focusable-has-no-interactive-content-akn7bn.md * Update inert.md * Apply suggestions from code review Co-authored-by: Wilco Fiers <[email protected]> * AGWG Updates (#2067) * Add (alt="") for clarity on empty alt * Resolve focus visible feedback * Tweak contrast rules * Tweak page title descriptive * Fix tests * Apply suggestions from code review Co-authored-by: Trevor R. Bostic <[email protected]> --------- Co-authored-by: Trevor R. Bostic <[email protected]> * [cae760] Frame has non-empty accessible name (#2034) * First pass in response to Feb 16 TF meeting * typo * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Wilco Fiers <[email protected]> * Move note about frame to background * Set height for frame * Test wants alphabetical contributors * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/iframe-non-empty-accessible-name-cae760.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Move note to background --------- Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Updating glossary definition. (#2069) * Bump yaml and zx (#2056) * Bump yaml and zx Bumps [yaml](https://github.com/eemeli/yaml) to 2.2.2 and updates ancestor dependency [zx](https://github.com/google/zx). These dependencies need to be updated together. Updates `yaml` from 1.10.2 to 2.2.2 - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v1.10.2...v2.2.2) Updates `zx` from 5.3.0 to 7.2.1 - [Release notes](https://github.com/google/zx/releases) - [Commits](google/zx@5.3.0...7.2.1) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect - dependency-name: zx dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Trigger CLA? --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <[email protected]> * new rule: ARIA required ID references exist (#2041) * new rule: ARIA required ID references exist * Address review comments Co-authored-by: Carlos Duarte <[email protected]> * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Apply suggestions from code review Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/aria-required-id-references-in6db8.md * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> --------- Co-authored-by: Carlos Duarte <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Tom Brunet <[email protected]> * scrollable element: clarify the title (#2083) * UpdateTableHeaderRule (#2074) * UpdateTableHeaderRule * Update table-header-cell-has-assigned-cells-d0f69e.md * trigger test * Update _rules/table-header-cell-has-assigned-cells-d0f69e.md Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * Adds apostrophe to mark the possessive form (#2080) Co-authored-by: Wilco Fiers <[email protected]> * Focus visible rule: Fix typo (#2082) * Contrast rules: Tweak background text (#2090) * Tweak name / description of Scrollable element keyboard (#2092) * Deprecate HTML page lang and xml:lang attributes have matching values (#2086) * Deprecate HTML page lang and xml:lang attributes have matching values * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> --------- Co-authored-by: Carlos Duarte <[email protected]> * Rephrase Applicability (#2079) * Rename file (#2078) * Move secondary requirement texts out of the background (#2060) * Move secondary requirement texts out of the background * Apply suggestions from code review * fix test * Fix failing test * Secondary reqs on ARIA rules * Update all secondary requirements * Typos * Fix failing tests * Update _rules/link-non-empty-accessible-name-c487ae.md Co-authored-by: Trevor R. Bostic <[email protected]> * Tweaked the language some more * Update rule design info for secondary requirements * Fix tests * Apply suggestions from code review Co-authored-by: Kathy Eng <[email protected]> * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Trevor R. Bostic <[email protected]> Co-authored-by: Kathy Eng <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * fix test on secondary requirements (#2102) * fix test on secondary requirements * More assertions * Update _rules/aria-required-id-references-in6db8.md Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Co-authored-by: Jean-Yves Moyen <[email protected]> * Update dependencies (including act-tools) (#2103) * fix test-assets not getting built right (#2104) * Update element-lang-valid-de46e4.md (#2100) Co-authored-by: Jean-Yves Moyen <[email protected]> * fix the approve-rule action (#2105) * Remove outdated accsupport note (#2111) * "Element with lang attribute has valid language tag" [de46e4]: Updated Failed Examples 4 and 5 to reflect Applicability (#2094) * Update element-lang-valid-de46e4.md Updated Failed examples 4 and 5 to reflect applicability * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Update _rules/element-lang-valid-de46e4.md Co-authored-by: Dan Tripp <[email protected]> --------- Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Dan Tripp <[email protected]> Co-authored-by: Carlos Duarte <[email protected]> * Text spacing rewrite (#1923) * Add new letter-spacing rule and deprecate old one * Add new word-spacing rule and deprecate old one * Clean up assumptions * Clean up * Clean up * Add new line-height rule and deprecate old one * Replace old letter spacing version rather than deprecating it * Replace old line height version rather than deprecating it * Replace old word spacing version rather than deprecating it * Target text nodes * Improve background note * Apply suggestion from review * Clean up * Target text nodes rather than their parents * Target text nodes rather than their parents * Add missing reference * Update example * Apply to parent of text nodes, not text nodes * Apply suggestions from code review Co-authored-by: Carlos Duarte <[email protected]> * Typos Co-authored-by: Carlos Duarte <[email protected]> * Typos --------- Co-authored-by: Carlos Duarte <[email protected]> * "Meta viewport allows for zoom" (b4f0c3): Explicit meaning of 'has' (#1994) * Explicit meaning of 'has' * Improve expectation and examples * Typo * Improve algorithm description Co-authored-by: Carlos Duarte <[email protected]> * Rephrase expectations * Streamline Applicability * Typo * Simplify expectations --------- Co-authored-by: Carlos Duarte <[email protected]> * Map Empty-heading rule to ARIA instead of WCAG (#2120) Co-authored-by: Jean-Yves Moyen <[email protected]> * Deprecate 4.1.1 rules (#2117) Co-authored-by: Jean-Yves Moyen <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: giacomo-petri <[email protected]> Co-authored-by: Carlos Duarte <[email protected]> Co-authored-by: Dan Tripp <[email protected]> Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Trevor R. Bostic <[email protected]> Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HelenBurge <[email protected]> Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Daniel Montalvo <[email protected]> Co-authored-by: Kathy Eng <[email protected]>

WilcoFiers added 2 commits May 25, 2023 13:16

Add (alt="") for clarity on empty alt

538c0eb

Resolve focus visible feedback

530f485

Jym77 approved these changes May 25, 2023

View reviewed changes

WilcoFiers added 2 commits May 25, 2023 14:01

Tweak contrast rules

d36f95b

Tweak page title descriptive

71d09cd

WilcoFiers changed the title ~~Agwg updates~~ AGWG Updates May 25, 2023

Fix tests

746778d

WilcoFiers marked this pull request as ready for review May 25, 2023 12:43

tbostic32 reviewed May 30, 2023

View reviewed changes

_rules/html-page-title-descriptive-c4a8a4.md Outdated Show resolved Hide resolved

tbostic32 reviewed May 30, 2023

View reviewed changes

_rules/image-button-non-empty-accessible-name-59796f.md Outdated Show resolved Hide resolved

_rules/image-non-empty-accessible-name-23a2a8.md Outdated Show resolved Hide resolved

kengdoj previously requested changes May 30, 2023

View reviewed changes

daniel-montalvo previously requested changes Jun 1, 2023

View reviewed changes

_rules/html-page-title-descriptive-c4a8a4.md Outdated Show resolved Hide resolved

_rules/image-button-non-empty-accessible-name-59796f.md Outdated Show resolved Hide resolved

Apply suggestions from code review

7f4cecd

Co-authored-by: Trevor R. Bostic <[email protected]>

WilcoFiers requested review from daniel-montalvo, kengdoj and tbostic32 June 2, 2023 14:24

daniel-montalvo approved these changes Jun 2, 2023

View reviewed changes

tbostic32 approved these changes Jun 2, 2023

View reviewed changes

Merge branch 'develop' into agwg-updates

0e8f78c

WilcoFiers merged commit ff0180f into develop Jun 15, 2023

WilcoFiers deleted the agwg-updates branch June 15, 2023 12:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AGWG Updates #2067

AGWG Updates #2067

WilcoFiers commented May 25, 2023 •

edited

Loading

kengdoj left a comment

AGWG Updates #2067

AGWG Updates #2067

Conversation

WilcoFiers commented May 25, 2023 • edited Loading

How to Review And Approve

kengdoj left a comment

Choose a reason for hiding this comment

WilcoFiers commented May 25, 2023 •

edited

Loading