DNM - Migrate ec2_vpc_egress_igw* modules and tests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llections#2146) SUMMARY Fix sanity errors happening with the ansible devel branch ERROR: Found 5 pylint issue(s) which need to be resolved: ERROR: plugins/modules/ec2_vpc_vgw.py:504:13: used-before-assignment: Using variable 'deleted_vgw' before assignment ERROR: plugins/modules/ecs_cluster.py:342:12: unreachable: Unreachable code ERROR: plugins/modules/ecs_cluster.py:364:12: unreachable: Unreachable code ERROR: plugins/modules/ecs_service.py:1251:12: unreachable: Unreachable code ERROR: plugins/modules/ecs_service.py:1266:12: unreachable: Unreachable code ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin
SUMMARY Create tests/sanity/ignore-2.19.txt ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…-collections#2150) SUMMARY Closes ansible-collections#2120 Closes ansible-collections#2019 Closes ansible-collections#2016 Prepare modules autoscaling_instance_refresh and autoscaling_instance_refresh_info for promotion: Refactor modules to use common code from ansible_collections.amazon.aws.plugins.module_utils.autoscaling Add type hinting Update integration tests ISSUE TYPE Feature Pull Request Reviewed-by: GomathiselviS Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis
…lections#2139) SUMMARY Added type hints and function descriptions. Updated return block of the module. ISSUE TYPE Docs Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Chappell Reviewed-by: GomathiselviS
…#2152) SUMMARY Refactor module ec2_vpc_egress_igw to use shared code from amazon.aws.plugins.module_utils.ec2 ec2_vpc_egress_igw - add support for tagging ISSUE TYPE Feature Pull Request New Module Pull Request COMPONENT NAME ec2_vpc_egress_igw Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS
abikouo
force-pushed
the
promote_ec2_vpc_egress_igw_v1
branch
2 times, most recently
from
3b145a2 to
a95c868
Compare
abikouo
force-pushed
the
promote_ec2_vpc_egress_igw_v1
branch
from
a95c868 to
6a5b8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modules have been migrated to
amazon.aws