Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sanity errors happening with the ansible devel branch #2146

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix sanity errors happening with the ansible devel branch #2146

merged 1 commit into from
Sep 20, 2024

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Sep 19, 2024 •
edited
Loading

SUMMARY

Fix sanity errors happening with the ansible devel branch

ERROR: Found 5 pylint issue(s) which need to be resolved:
ERROR: plugins/modules/ec2_vpc_vgw.py:504:13: used-before-assignment: Using variable 'deleted_vgw' before assignment
ERROR: plugins/modules/ecs_cluster.py:342:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_cluster.py:364:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_service.py:1251:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_service.py:1266:12: unreachable: Unreachable code
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b08892a0fb99488fb87fe6e43e47b1e7

❌ ansible-galaxy-importer FAILURE in 5m 41s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 37s
✔️ ansible-test-splitter SUCCESS in 4m 15s
✔️ integration-community.aws-1 SUCCESS in 17m 29s
✔️ integration-community.aws-2 SUCCESS in 7m 50s
Skipped 20 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Sep 20, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/fcb99fc459a54606928b02d8e8f025be

❌ ansible-galaxy-importer FAILURE in 5m 02s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 35s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-community.aws-1 SUCCESS in 18m 13s
✔️ integration-community.aws-2 SUCCESS in 8m 11s
Skipped 20 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 008b515 into ansible-collections:main Sep 20, 2024
96 checks passed
@patchback Patchback
Copy link

patchback bot commented Sep 20, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/008b515022ef0dbc19f964e174f803e48de9871f/pr-2146

Backported as #2149

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 20, 2024
@alinabuzachis @patchback
Fix sanity errors happening with the ansible devel branch (#2146)
bbab30c 
SUMMARY

Fix sanity errors happening with the ansible devel branch
ERROR: Found 5 pylint issue(s) which need to be resolved:
ERROR: plugins/modules/ec2_vpc_vgw.py:504:13: used-before-assignment: Using variable 'deleted_vgw' before assignment
ERROR: plugins/modules/ecs_cluster.py:342:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_cluster.py:364:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_service.py:1251:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_service.py:1266:12: unreachable: Unreachable code

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
(cherry picked from commit 008b515)
@patchback patchback bot mentioned this pull request Sep 20, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 20, 2024
@patchback
Fix sanity errors happening with the ansible devel branch (#2146) (#2149
cef8ee7 
)

This is a backport of PR #2146 as merged into main (008b515).
SUMMARY

Fix sanity errors happening with the ansible devel branch
ERROR: Found 5 pylint issue(s) which need to be resolved:
ERROR: plugins/modules/ec2_vpc_vgw.py:504:13: used-before-assignment: Using variable 'deleted_vgw' before assignment
ERROR: plugins/modules/ecs_cluster.py:342:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_cluster.py:364:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_service.py:1251:12: unreachable: Unreachable code
ERROR: plugins/modules/ecs_service.py:1266:12: unreachable: Unreachable code


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

Assignees
No one assigned
Labels
backport-8 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alinabuzachis @abikouo