Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "skip_matching" preference in autoscaling_instance_refresh #2016

Closed
1 task done
gtie opened this issue Dec 6, 2023 · 0 comments · Fixed by #2150
Closed
1 task done

Add support for "skip_matching" preference in autoscaling_instance_refresh #2016

gtie opened this issue Dec 6, 2023 · 0 comments · Fixed by #2150

Comments

@gtie
Copy link

gtie commented Dec 6, 2023

Summary

AWS enables users to turn on a "skip_matching" preference when starting an Instance Refresh. The Ansible module OTOH does not expose that preference.

Issue Type

Feature Idea

Component Name

autoscaling_instance_refresh

Additional Information

Once implemented the following should work:

    - name: START INSTANCE REFRESH
      community.aws.ec2_asg_instance_refresh:
        name: "{{ asg_name }}"
        state: started
        preferences:
          skip_matching: true

Looking at the code of the current Ansible module, the only real change is to add it to the list of allowed preferences and document it. The plumbing is already there to support passing that preference to the AWS API.

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@abikouo abikouo mentioned this issue Sep 20, 2024
Merged
alinabuzachis pushed a commit to GomathiselviS/community.aws that referenced this issue Oct 1, 2024
@abikouo @alinabuzachis
autoscaling_instance_refresh - prepare modules for promotion (ansible…
1790f0c 
…-collections#2150)

SUMMARY
Closes ansible-collections#2120
Closes ansible-collections#2019
Closes ansible-collections#2016
Prepare modules autoscaling_instance_refresh and autoscaling_instance_refresh_info for promotion:

Refactor modules to use common code from ansible_collections.amazon.aws.plugins.module_utils.autoscaling
Add type hinting
Update integration tests


ISSUE TYPE


Feature Pull Request

Reviewed-by: GomathiselviS
Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

autoscaling_instance_refresh - prepare modules for promotion abikouo/community.aws
1 participant
@gtie