Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoscaling_instance_refresh: add "max_healthy_percentage" (MaxHealthyPercentage) #2120

Closed
1 task done
steadfasterX opened this issue Jul 8, 2024 · 0 comments · Fixed by #2150
Closed
1 task done

autoscaling_instance_refresh: add "max_healthy_percentage" (MaxHealthyPercentage) #2120

steadfasterX opened this issue Jul 8, 2024 · 0 comments · Fixed by #2150

Comments

@steadfasterX
Copy link

Summary

I want to ensure that a new instance gets started first before an older one get killed. according to the AWS documentation this should be possible by setting MaxHealthyPercentage higher than 100.

Issue Type

Feature Idea

Component Name

autoscaling_instance_refresh

Additional Information

- name: "Refresh: {{ aws_autoscaling_grpname }}"
  community.aws.autoscaling_instance_refresh:
    aws_access_key: "{{ vault_aws_access_key }}"
    aws_secret_key: "{{ vault_aws_secret_key }}"
    region: "{{ aws_region }}"
    name: "{{ aws_autoscaling_grpname }}"
    preferences:
      min_healthy_percentage: "{{ aws_autoscaling_min_healthy_perc }}"
      instance_warmup: "{{ aws_autoscaling_warmup }}"
      max_healthy_percentage: 110 # <------------------
    state: started
  register: refreshid

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@abikouo abikouo mentioned this issue Sep 20, 2024
Merged
alinabuzachis pushed a commit to GomathiselviS/community.aws that referenced this issue Oct 1, 2024
@abikouo @alinabuzachis
autoscaling_instance_refresh - prepare modules for promotion (ansible…
1790f0c 
…-collections#2150)

SUMMARY
Closes ansible-collections#2120
Closes ansible-collections#2019
Closes ansible-collections#2016
Prepare modules autoscaling_instance_refresh and autoscaling_instance_refresh_info for promotion:

Refactor modules to use common code from ansible_collections.amazon.aws.plugins.module_utils.autoscaling
Add type hinting
Update integration tests


ISSUE TYPE


Feature Pull Request

Reviewed-by: GomathiselviS
Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

autoscaling_instance_refresh - prepare modules for promotion abikouo/community.aws
1 participant
@steadfasterX