Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role icon support #1278

Merged
merged 10 commits into from
Oct 23, 2021
Merged

Role icon support #1278

merged 10 commits into from
Oct 23, 2021

Conversation

conorwastakenwastaken
Copy link
Contributor

@conorwastakenwastaken conorwastakenwastaken commented Sep 30, 2021 •
edited
Loading

New properties

  • Role#icon
  • Role#iconURL
  • Role#unicodeEmoji

Misc Updates

  • Added abilty to create a new role with an icon/emoji (4b5a8ee)
  • Added documentation for editing a role icon/emoji (4b5a8ee)
  • Added support for the guildRoleUpdate event to display role icon/emoji changes (6645864)
  • Added documentation for new ROLE_ICONS guild feature (3c45b6c)

DonovanDMC
DonovanDMC suggested changes Sep 30, 2021
View reviewed changes
lib/gateway/Shard.js Outdated Show resolved Hide resolved
lib/gateway/Shard.js Outdated Show resolved Hide resolved
@bsian03
Copy link
Collaborator

bsian03 commented Sep 30, 2021

it's not october yet

DonovanDMC
DonovanDMC suggested changes Oct 1, 2021
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@conorwastakenwastaken @DonovanDMC
Fix spacing
e115f3b 
Co-authored-by: Donovan Daniels <[email protected]>
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request Oct 3, 2021
@DonovanDMC
several changes
1000105 
rename abalabahaha/eris#1216 -> abalabahaha/eris#1279
rename abalabahaha/eris#1210 -> abalabahaha/eris#1280
rename abalabahaha/eris#1273 -> abalabahaha/eris#1281
add abalabahaha/eris#1275
add abalabahaha/eris#1276
add abalabahaha/eris#1277
add abalabahaha/eris#1278
@bsian03 bsian03 added this to the 0.16.0 milestone Oct 3, 2021
bsian03
bsian03 requested changes Oct 8, 2021
View reviewed changes
lib/Client.js Show resolved Hide resolved
lib/gateway/Shard.js Outdated Show resolved Hide resolved
@bsian03 bsian03 merged commit 59a35bb into abalabahaha:dev Oct 23, 2021
@conorwastakenwastaken conorwastakenwastaken deleted the role-icons branch October 24, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonovanDMC DonovanDMC DonovanDMC requested changes

@bsian03 bsian03 bsian03 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@conorwastakenwastaken @bsian03 @DonovanDMC @abalabahaha