Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make shard ID optional for some events #1277

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Make shard ID optional for some events #1277

merged 4 commits into from
Nov 15, 2021

Conversation

DonovanDMC
Copy link
Contributor

As stated in Discord, the debug, error, warn, and unknown events can be emitted without the shard id.

@DonovanDMC DonovanDMC changed the base branch from master to dev September 18, 2021 02:11
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request Oct 3, 2021
@DonovanDMC
several changes
1000105 
rename abalabahaha/eris#1216 -> abalabahaha/eris#1279
rename abalabahaha/eris#1210 -> abalabahaha/eris#1280
rename abalabahaha/eris#1273 -> abalabahaha/eris#1281
add abalabahaha/eris#1275
add abalabahaha/eris#1276
add abalabahaha/eris#1277
add abalabahaha/eris#1278
@abalabahaha abalabahaha changed the title make id optional for some events Make shard ID optional for some events Nov 15, 2021
@abalabahaha abalabahaha merged commit 7c53aeb into abalabahaha:dev Nov 15, 2021
@abalabahaha abalabahaha added this to the 0.16.0 milestone Nov 15, 2021
@DonovanDMC DonovanDMC deleted the event-types branch November 15, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalabahaha abalabahaha abalabahaha approved these changes

Assignees
No one assigned
Labels
typings
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DonovanDMC @abalabahaha @bsian03