-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use process warnings for deprecations #1276
Conversation
Array ops are apparently faster than Set ops in V8? https://discord.com/channels/831967755447828491/884930349119991849/885222846815678495
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed structure around a bit in response to discussion activity. Looking for feedback on the codes themselves.
I also think it would be a good idea to rewrite some of these existing messages to include more context and provide migration paths away from the problem, rather than focusing on being short. How do we feel about this?
Rewrote the rest of the warning descriptions to be consistent with each other. I've elected not to copy these changes to warnings emitted on the client to avoid potentially breaking things, but if it's desired anyway, I can copy my changes to those as well. Please double check my grammar and format. |
Single `embed` options were un-deprecated in dc72ad9
Merged latest |
Addresses #1274. Adds process warning emits alongside existing deprecation-related client
warn
emits. To avoid emitting the same process warning multiple times, uses a wrapper aroundprocess.emitWarning
that checks if the given warning code has already been used, and if so, skips emitting the warning again.