Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0-rc.8 release #6632

Merged
merged 12 commits into from
May 11, 2023
Merged

v1.0.0-rc.8 release #6632

merged 12 commits into from
May 11, 2023

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented May 8, 2023


name: Release Checklist Template
about: Checklist of versioning to create a taggable commit for Zebra
title: ''
labels:
assignees: ''


Versioning

How to Increment Versions

Zebra follows semantic versioning. Semantic versions look like: MAJOR.MINOR.PATCH[-TAG.PRE-RELEASE]

The draft zebrad changelog will have an automatic version bump. This version is based on the labels on the PRs in the release.

Check that the automatic zebrad version increment matches the changes in the release:

If we're releasing a mainnet network upgrade, it is a major release:

  1. Increment the major version of all the Zebra crates.
  2. Increment the patch version of the tower crates.

If we're not releasing a mainnet network upgrade, check for features, major changes, deprecations, and removals. If this release has any, it is a minor release:

  1. Increment the minor version of zebrad.
  2. Increment the pre-release version of the other crates.
  3. Increment the patch version of the tower crates.

Otherwise, it is a patch release:

  1. Increment the patch version of zebrad.
  2. Increment the pre-release version of the other crates.
  3. Increment the patch version of the tower crates.

Zebra's Rust API is not stable or supported, so we keep all the crates on the same beta pre-release version.

Version Locations

Once you know which versions you want to increment, you can find them in the:

zebrad (rc):

  • zebrad Cargo.toml
  • README.md
  • book/src/user/docker.md

crates (beta):

  • zebra-* Cargo.tomls

tower (patch):

  • tower-* Cargo.tomls

auto-generated:

  • Cargo.lock: run cargo build after updating all the Cargo.tomls

Version Tooling

You can use fastmod to interactively find and replace versions.

For example, you can do something like:

fastmod --extensions rs,toml,md --fixed-strings '1.0.0-rc.0' '1.0.0-rc.1' zebrad README.md zebra-network/src/constants.rs book/src/user/docker.md
fastmod --extensions rs,toml,md --fixed-strings '1.0.0-beta.15' '1.0.0-beta.16' zebra-*
fastmod --extensions rs,toml,md --fixed-strings '0.2.30' '0.2.31' tower-batch tower-fallback
cargo build

If you use fastmod, don't update versions in CHANGELOG.md or zebra-dependencies-for-audit.md.

README

Update the README to:

  • Remove any "Known Issues" that have been fixed
  • Update the "Build and Run Instructions" with any new dependencies.
    Check for changes in the Dockerfile since the last tag: git diff <previous-release-tag> docker/Dockerfile.
  • If Zebra has started using newer Rust language features or standard library APIs, update the known working Rust version in the README, book, and Cargo.tomls

You can use a command like:

      fastmod --fixed-strings '1.58' '1.65'

Checkpoints

For performance and security, we want to update the Zebra checkpoints in every release.
You can copy the latest checkpoints from CI by following the zebra-checkpoints README.

Missed Dependency Updates

Sometimes dependabot misses some dependency updates, or we accidentally turned them off.

Here's how we make sure we got everything:

  1. Run cargo update on the latest main branch, and keep the output
  2. If needed, update deny.toml
  3. Open a separate PR with the changes, including the output of cargo update

Change Log

Important: Any merge into main deletes any edits to the draft changelog.
Once you are ready to tag a release, copy the draft changelog into CHANGELOG.md.

We use the Release Drafter workflow to automatically create a draft changelog. We follow the Keep a Changelog format.

To create the final change log:

  • Copy the latest draft changelog into CHANGELOG.md (there can be multiple draft releases)
  • Delete any trivial changes. Keep the list of those, to include in the PR
  • Combine duplicate changes
  • Edit change descriptions so they are consistent, and make sense to non-developers
  • Check the category for each change
    • Prefer the "Fix" category if you're not sure

Change Categories

From "Keep a Changelog":

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Release support constants

Needed for the end of support feature. Please update the following constants in this file:

  • ESTIMATED_RELEASE_HEIGHT (required) - Replace with the estimated height you estimate the release will be tagged.


    - Find where the Zcash blockchain tip is now by using a Zcash explorer or other tool.
    - Consider there are aprox 1152 blocks per day (with the current Zcash 75 seconds spacing).
    - So for example if you think the release will be tagged somewhere in the next 3 days you can add 1152 * 3 to the current tip height and use that value here.

  • EOS_PANIC_AFTER (optional) - Replace if you want the release to be valid for a different numbers of days into the future. The default here is 120 days.

Create the Release

Create the Release PR

After you have the version increments, the updated checkpoints, any missed dependency updates,
and the updated changelog:

  • Make sure the PRs with the new checkpoint hashes and missed dependencies are already merged
  • Push the version increments, the updated changelog and the release constants into a branch
    (for example: bump-v1.0.0-rc.0 - this needs to be different to the tag name)
  • Create a release PR by adding &template=release-checklist.md to the comparing url (Example).
    • Add the list of deleted changelog entries as a comment to make reviewing easier.
  • Freeze the batched queue using Mergify.
  • Mark all the release PRs as Critical priority, so they go in the urgent Mergify queue.

Create the Release

  • Once the PR has been merged, create a new release using the draft release as a base, by clicking the Edit icon in the draft release
  • Set the tag name to the version tag,
    for example: v1.0.0-rc.0
  • Set the release to target the main branch
  • Set the release title to Zebra followed by the version tag,
    for example: Zebra 1.0.0-rc.0
  • Replace the prepopulated draft changelog in the release description with the final changelog you created;
    starting just after the title ## [Zebra ... of the current version being released,
    and ending just before the title of the previous release.
  • Mark the release as 'pre-release', until it has been built and tested
  • Publish the pre-release to GitHub using "Publish Release"
  • Delete all the draft releases from the list of releases

Binary Testing

Telling Zebra Users

  • Post a summary of the important changes in the release in the #arborist and #communications Slack channels
    If the release contains new features (major or minor), or high-priority bug fixes:
  • Ask the team about doing a blog post

Release Failures

If building or running fails after tagging:

  1. Fix the bug that caused the failure
  2. Increment versions again, following these instructions from the start
  3. Update the code and documentation with a new git tag
  4. Update CHANGELOG.md with details about the fix
  5. Tag a new release

@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #6632 (6eb72cb) into main (25ca4cc) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6632      +/-   ##
==========================================
+ Coverage   77.98%   78.08%   +0.10%     
==========================================
  Files         309      309              
  Lines       40664    40665       +1     
==========================================
+ Hits        31711    31754      +43     
+ Misses       8953     8911      -42     

@oxarbitrage
Copy link
Contributor Author

Trivial

  • build(deps): bump bitflags from 2.1.0 to 2.2.1 (#6561)
  • build(deps): bump codecov/codecov-action from 3.1.2 to 3.1.3 (#6554)
  • build(deps): bump dirs from 5.0.0 to 5.0.1 (#6592)
  • build(deps): bump displaydoc from 0.2.3 to 0.2.4 (#6610)
  • build(deps): bump metrics from 0.20.1 to 0.21.0 and metrics-exporter-prometheus from 0.11.0 to 0.12.0 (#6531)
  • build(deps): bump regex from 1.7.3 to 1.8.1 (#6555)
  • build(deps): bump reqwest from 0.11.16 to 0.11.17 (#6591)
  • build(deps): bump sentry from 0.30.0 to 0.31.0 (#6546)
  • build(deps): bump serde_with from 2.3.2 to 2.3.3 (#6588)
  • build(deps): bump serde_with from 2.3.3 to 3.0.0 (#6599)
  • build(deps): bump tj-actions/changed-files from 35.8.0 to 35.9.0 (#6559)
  • build(deps): bump tj-actions/changed-files from 35.9.0 to 35.9.2 (#6590)
  • build(deps): bump tokio from 1.27.0 to 1.28.0 (#6572)
  • build(deps): bump tokio-stream from 0.1.12 to 0.1.14 (#6573)
  • build(deps): bump tokio-util from 0.7.7 to 0.7.8 (#6570)
  • build(deps): bump tracing-subscriber from 0.3.16 to 0.3.17 (#6560)
  • build(deps): bump w9jds/firebase-action from 11.24.1 to 11.30.1 (#6622)
  • change(ci): Generate mainnet checkpoints in CI (#6550)
  • change(ci): Generate testnet checkpoints in CI (#6581)
  • change(ci): Split checking for cached state disks into its own workflow (#6576)
  • change(release): Add arborist and comms summaries to the release checklist (#6565)
  • change: Add a template for private security issues (#6594)
  • feat(zebra-network): add user agent argument (#6601)
  • feat(zebrad): Refuse to run zebrad when release is too old (#6351)
  • fix(build): sync LWD builder with our build-docker-image.yml workflow (#6634)
  • fix(ci): Avoid inbound service overloads and fix failing tests (#6537)
  • fix(ci): Delete mainnet and testnet disks separately (#6582)
  • fix(ci): Update cached disk patch job name (#6615)
  • fix(log): Fix confusing comments and error messages in zebra-checkpoints (#6579)
  • fix: Avoid wrong test results for modified JoinSplits (#6604)

@oxarbitrage
Copy link
Contributor Author

All these are repeated or not important to mention:

  • change(release): Add arborist and comms summaries to the release checklist (#6565)

  • change(utils): Add a direct connection mode to zebra-checkpoints (#6516)

  • build(deps): bump tj-actions/changed-files from 35.8.0 to 35.9.0 (#6559)

  • build(deps): bump tj-actions/changed-files from 35.9.0 to 35.9.2 (#6590)

  • change(ci): Generate mainnet checkpoints in CI (#6550)

  • change(ci): Generate testnet checkpoints in CI (#6581)

  • change(ci): Split checking for cached state disks into its own workflow (#6576)

  • change(release): Add arborist and comms summaries to the release checklist (#6565)

  • change(utils): Add a direct connection mode to zebra-checkpoints (#6516)

  • change: Add a template for private security issues (#6594)

  • fix(log): Fix confusing comments and error messages in zebra-checkpoints (#6579)

  • fix(net): Avoid a rare panic when a connection is dropped (#6566)

  • fix(net): Avoid some self-connection nonce removal attacks (#6410)

  • fix(net): Reject nodes using ZClassic ports, and warn if configured with those ports (#6567)

  • fix(test): Prevent finalized_equals_pushed_genesis prop test from panicking (#6552)

@oxarbitrage oxarbitrage added P-Critical 🚑 and removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels May 9, 2023
@oxarbitrage oxarbitrage marked this pull request as ready for review May 9, 2023 18:21
@oxarbitrage oxarbitrage requested review from a team as code owners May 9, 2023 18:21
@oxarbitrage oxarbitrage requested review from upbqdn and teor2345 and removed request for a team May 9, 2023 18:21
@oxarbitrage oxarbitrage added the S-blocked Status: Blocked on other tasks label May 9, 2023
@oxarbitrage
Copy link
Contributor Author

This is blocked on #6624

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems like the missed dependency update got skipped.

zebrad/src/components/sync/end_of_support.rs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Cargo.lock Show resolved Hide resolved
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label May 9, 2023
@teor2345 teor2345 removed the S-blocked Status: Blocked on other tasks label May 11, 2023
@teor2345
Copy link
Contributor

There was an internal GitHub error downloading an action in the testnet test, but testnet tests aren't required to merge, because testnet is unstable anyway:
https://github.com/ZcashFoundation/zebra/actions/runs/4942789784/jobs/8849583735#step:1:25

mergify bot added a commit that referenced this pull request May 11, 2023
@mergify mergify bot merged commit 0190882 into main May 11, 2023
@mergify mergify bot deleted the bump-v1.0.0-rc.8 branch May 11, 2023 22:15
@mpguerra mpguerra linked an issue May 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag Zebra 1.0.0-rc.8 release
2 participants