-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(deps): Upgrade zcash_script to 0.1.12 to match zcashd 5.5.0 #6624
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6624 +/- ##
==========================================
+ Coverage 77.92% 77.93% +0.01%
==========================================
Files 309 309
Lines 40653 40664 +11
==========================================
+ Hits 31678 31693 +15
+ Misses 8975 8971 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@mergify refresh |
✅ Pull request refreshed |
@Mergifyio refresh |
✅ Pull request refreshed |
@Mergifyio refresh |
✅ Pull request refreshed |
I forgot this check when making this PR. |
Motivation
We need to upgrade to the
zcash_script
dependency to matchzcashd
5.5.0.Closes #6535
Specifications
Zcash script handling is not specified, so we just run
zcashd
's code.Complex Code or Requirements
This is unlikely to be a consensus-critical change, because
zcashd
has not changed its script handling. However, it has refactored some of its transaction parsing code.Solution
Review
This is a high priority because it's blocking the missed version updates, which is needed to tag the next release.
Reviewer Checklist