Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate dependencies from deny.toml once ed25519-zebra and zcashd are released #6638

Closed
Tracked by #6859 ...
mpguerra opened this issue May 9, 2023 · 6 comments · Fixed by #7238
Closed
Tracked by #6859 ...
Assignees
Labels
A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage

Comments

@mpguerra
Copy link
Contributor

mpguerra commented May 9, 2023

Motivation

We want to remove as many duplicate dependencies as possible from the zebra codebase. This should be possible after zcash/zcash#6648 currently planned for the the zcashd 5.6.0 release.

Specifications

With the zcashd 5.6.0 release, we we can upgrade and delete these dependencies in deny.toml

zebra/deny.toml

Lines 71 to 74 in 39c5997

# wait for zcashd and zcash_script to upgrade
# https://github.com/ZcashFoundation/zcash_script/pulls
{ name = "metrics", version = "=0.20.1" },
{ name = "sha2", version = "=0.9.9" },

zebra/deny.toml

Lines 85 to 89 in 39c5997

# wait for zebra-chain to upgrade
{ name = "secp256k1", version = "=0.21.3" },
# wait for zebra-chain to upgrade `secp256k1`
{ name = "secp256k1-sys", version = "=0.4.2" },

zebra/deny.toml

Lines 96 to 97 in 39c5997

# wait for zcash_address to upgrade
{ name = "bs58", version = "=0.4.0" },

zebra/deny.toml

Lines 76 to 78 in 39c5997

# wait for ed25519-zebra, indexmap, metrics-util, and metrics to upgrade
# ed25519-zebra/hashbrown: https://github.com/ZcashFoundation/ed25519-zebra/pull/65
{ name = "ahash", version = "=0.7.6" },

zebra/deny.toml

Lines 64 to 65 in 4b6e2fe

# wait for zcash_primitives to remove duplicated dependencies
{ name = "block-buffer", version = "=0.9.0" },

Complex Code or Requirements

Testing

Related Work

@mpguerra mpguerra added S-blocked Status: Blocked on other tasks C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels May 9, 2023
@mpguerra mpguerra added this to Zebra May 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra May 9, 2023
@teor2345
Copy link
Contributor

teor2345 commented May 9, 2023

@mpguerra the next step here is to publish an ed25519-zebra release. The updated dependencies are in its main branch, but they haven't been released yet.

Once ed25519-zebra is done, it should be automatically picked up by the zcashd and zcash_script release processes. Then Zebra will pick it up automatically using dependabot.

Just a note: the deny.toml entries linked in the ticket will be outdated by the time we do this ticket, because PR #6624 will modify them.

(This ticket is also related to ZcashFoundation/ed25519-zebra#77 , because the release instructions for all our crates should include updating dependencies.)

@teor2345 teor2345 changed the title Remove duplicate dependencies from deny.toml once zcashd 5.6.0 is released Remove duplicate dependencies from deny.toml once ed25519-zebra and zcashd are released May 17, 2023
@daira
Copy link
Contributor

daira commented Jun 7, 2023

Note that we are cutting an rc of zcashd, so this is at risk of not getting into zcashd 5.6.0 if it is not done very soon.

@mpguerra
Copy link
Contributor Author

tentatively scheduling for next sprint

@teor2345
Copy link
Contributor

This needs to be done as part of #6859, can we close this ticket and just make it part of the PR for #6959?

(The duplicate dependency tests don't look for extra allowed duplicates, only new duplicates. So it needs to be a manual change as part of the dependency update.)

@teor2345
Copy link
Contributor

I'm going to close this as incomplete rather than trying to track its dependencies separately, because it should happen in the same PR as #6859.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Jun 15, 2023
@teor2345
Copy link
Contributor

Splitting this out of #6859

@teor2345 teor2345 reopened this Jul 17, 2023
@teor2345 teor2345 added A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup and removed S-blocked Status: Blocked on other tasks labels Jul 17, 2023
@arya2 arya2 self-assigned this Jul 17, 2023
@mergify mergify bot closed this as completed in #7238 Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants