Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(docs): Add cargo clean step to crate publishing steps #6959

Merged
merged 1 commit into from
Jun 14, 2023
Merged

change(docs): Add cargo clean step to crate publishing steps #6959

merged 1 commit into from
Jun 14, 2023

Conversation

dconnolly
Copy link
Contributor

Motivation

It really sucks to run out of storage space in the middle of publishing a bunch of crates.

Solution

Suggest a cargo clean in the zebra workspace before attempting cargo release publish. I ran out of storage space mid-release, so

Review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?

@dconnolly dconnolly added A-docs Area: Documentation C-enhancement Category: This is an improvement P-Low ❄️ labels Jun 14, 2023
@dconnolly dconnolly requested a review from a team as a code owner June 14, 2023 16:27
@dconnolly dconnolly requested review from upbqdn and removed request for a team June 14, 2023 16:27
@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 14, 2023
mergify bot added a commit that referenced this pull request Jun 14, 2023
@mergify
Merge of #6959
88e1cb0
@mergify mergify bot mentioned this pull request Jun 14, 2023
Closed
@mergify mergify bot merged commit e870c38 into main Jun 14, 2023
@mergify mergify bot deleted the dconnolly-patch-2 branch June 14, 2023 19:09
@teor2345 teor2345 mentioned this pull request Jun 14, 2023
Closed
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

Assignees
No one assigned
Labels
A-docs Area: Documentation C-enhancement Category: This is an improvement C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconnolly @upbqdn