Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(ci): Split checking for cached state disks into its own workflow #6576

Merged
merged 7 commits into from
May 3, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

We want to check for cached state disks for both mainnet and testnet.

This is part of #6367.

Specifications

https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow

Solution

  • Split the cached state disk search into a new reusable workflow
  • Call it twice: once for the default network (mainnet), and once for testnet

Related fixes:

  • Fix a parameter vars.ZCASH_NETWORK that should prefer inputs.network first

Review

This is a routine CI change.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

Use the outputs of the new job to build a cached state on testnet and generate testnet checkpoints in CI.

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-Medium ⚡ labels Apr 26, 2023
@teor2345 teor2345 self-assigned this Apr 26, 2023
@teor2345 teor2345 requested a review from a team as a code owner April 26, 2023 20:55
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team April 26, 2023 20:55
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Apr 26, 2023
@teor2345
Copy link
Contributor Author

This seems to be working as expected for mainnet:

STATE_VERSION: 25
Disk: lwd-cache-main-fb3fec0-v25-mainnet-tip-061314
Disk: zebrad-cache-6556-merge-a2ca4de-v25-mainnet-tip-u-140654
Disk: zebrad-cache-6039-merge-62c8ecc-v25-mainnet-checkpoint-053559

https://github.com/ZcashFoundation/zebra/actions/runs/4813941265/jobs/8571075779#step:6:46

And testnet (which has no disks yet):

STATE_VERSION: 25
No TIP disk found for LWD
No TIP disk found for ZEBRA
No CHECKPOINT found for ZEBRA

https://github.com/ZcashFoundation/zebra/actions/runs/4813941265/jobs/8571075399#step:6:46

@teor2345 teor2345 force-pushed the ci-split-get-disks branch from fd0d8f3 to c98dc4f Compare April 27, 2023 05:39
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mergify bot added a commit that referenced this pull request May 3, 2023
@mergify mergify bot merged commit aea3833 into main May 3, 2023
@mergify mergify bot deleted the ci-split-get-disks branch May 3, 2023 12:04
@oxarbitrage oxarbitrage mentioned this pull request May 9, 2023
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants