Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump rocksdb from 0.20.1 to 0.21.0 #6640

Merged
merged 1 commit into from
May 16, 2023
Merged

build(deps): bump rocksdb from 0.20.1 to 0.21.0 #6640

merged 1 commit into from
May 16, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 9, 2023 •
edited
Loading

Depends-On: #6632

Bumps rocksdb from 0.20.1 to 0.21.0.

Release notes

Sourced from rocksdb's releases.

v0.21.0

What's Changed

New Contributors

Full Changelog: rust-rocksdb/rust-rocksdb@v0.20.1...v0.21.0

Changelog

Sourced from rocksdb's changelog.

0.21.0 (2023-05-09)

  • Add doc-check to CI with fix warnings in docs (YuraKotov)
  • Fix rustdoc::broken-intra-doc-links errors (YuraKotov)
  • Fix 32-bit ARM build (EyeOfPython)
  • Allow specifying checksum type (romanz)
  • Enable librocksdb-sys to be built by rustc_codegen_cranelift (ZePedroResende)
  • Update to RocksDB 8.0.0 (niklasf)
  • Block cache creation failure is not recoverable (niklasf)
  • Update iOS min version to 12 in the build script (mighty840)
  • Actually enable io-uring (niklasf)
  • Update to RocksDB 8.1.1 (niklasf)
  • Add Cache::new_hyper_clock_cache() (niklasf)
  • Retrieve Value from KeyMayExist if value found in Cache or Memory (Congyuwang)
  • Support for comparators as closures (pegesund)
  • Fix bug in DBWALIterator that would miss updates (Zagitta)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner May 9, 2023 15:56
@dependabot dependabot bot requested review from teor2345 and removed request for a team May 9, 2023 15:56
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023 •
edited
Loading

Codecov Report

Merging #6640 (6ae4e8f) into main (d58d827) will decrease coverage by 0.04%.
The diff coverage is 85.96%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6640      +/-   ##
==========================================
- Coverage   78.10%   78.06%   -0.04%     
==========================================
  Files         309      310       +1     
  Lines       40665    40691      +26     
==========================================
+ Hits        31760    31766       +6     
- Misses       8905     8925      +20

@teor2345
Copy link
Contributor

teor2345 commented May 9, 2023

@dependabot recreate

@teor2345 teor2345 added the C-bug Category: This is a bug label May 9, 2023
teor2345
teor2345 previously approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a bunch of RocksDB Rust and C++ bugs from release 8.0.0 onwards:
https://github.com/facebook/rocksdb/releases

@dependabot dependabot bot force-pushed the dependabot/cargo/rocksdb-0.21.0 branch from c4ff903 to f479edd Compare May 9, 2023 22:37
@gustavovalverde
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/cargo/rocksdb-0.21.0 branch from f479edd to a3a63ed Compare May 10, 2023 01:08
@gustavovalverde
Copy link
Member

@teor2345 this was approved but it won't get merged because of https://github.com/ZcashFoundation/zebra/actions/runs/4932026472/jobs/8814658241#step:4:14

@teor2345
Copy link
Contributor

@teor2345 this was approved but it won't get merged because of https://github.com/ZcashFoundation/zebra/actions/runs/4932026472/jobs/8814658241#step:4:14

This can be fixed by cargo update --package [email protected], but there's no point doing that until after the release, because there will be dependency merge conflicts, and the merge queue is currently frozen.

@teor2345 teor2345 self-assigned this May 10, 2023
@dependabot dependabot bot force-pushed the dependabot/cargo/rocksdb-0.21.0 branch from a3a63ed to da95096 Compare May 10, 2023 08:32
@gustavovalverde
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/cargo/rocksdb-0.21.0 branch 2 times, most recently from 8544c76 to 1778abf Compare May 11, 2023 22:17
teor2345
teor2345 previously approved these changes May 11, 2023
View reviewed changes
@dependabot dependabot bot force-pushed the dependabot/cargo/rocksdb-0.21.0 branch from 7ce47b2 to 8544c76 Compare May 11, 2023 23:48
mergify bot added a commit that referenced this pull request May 13, 2023
@mergify
Merge of #6640
2a13f81
@mergify mergify bot mentioned this pull request May 13, 2023
Closed
@dependabot
build(deps): bump rocksdb from 0.20.1 to 0.21.0
6ae4e8f 
Bumps [rocksdb](https://github.com/rust-rocksdb/rust-rocksdb) from 0.20.1 to 0.21.0.
- [Release notes](https://github.com/rust-rocksdb/rust-rocksdb/releases)
- [Changelog](https://github.com/rust-rocksdb/rust-rocksdb/blob/master/CHANGELOG.md)
- [Commits](rust-rocksdb/rust-rocksdb@v0.20.1...v0.21.0)

---
updated-dependencies:
- dependency-name: rocksdb
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/rocksdb-0.21.0 branch from 1778abf to 6ae4e8f Compare May 14, 2023 15:07
mergify bot added a commit that referenced this pull request May 15, 2023
@mergify
Merge of #6640
ae64aeb
@mergify mergify bot mentioned this pull request May 15, 2023
Closed
@mergify mergify bot merged commit 185d138 into main May 16, 2023
@mergify mergify bot deleted the dependabot/cargo/rocksdb-0.21.0 branch May 16, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@teor2345 teor2345

Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @gustavovalverde