-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): Update timeout for Zebra sync tests #4918
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4918 +/- ##
==========================================
- Coverage 79.09% 79.03% -0.06%
==========================================
Files 309 309
Lines 38781 38781
==========================================
- Hits 30673 30651 -22
- Misses 8108 8130 +22 |
I'm still seeing a timeout in the Zebra update to tip test, even with the updated checkpoints in PR #4919:
https://github.com/ZcashFoundation/zebra/runs/7918830518?check_suite_focus=true#step:6:143 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to increase timeouts for the failing Zebra update to tip and lightwalletd full sync tests.
We probably need to update the timeouts for all the lightwalletd tests that sync Zebra's cached state. Some of them won't run until the lightwalletd full sync passes, but they'll have the same issue.
b4914d1
to
7860d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alfredo and I updated all the timeouts for the failing tests.
If CI passes, this will merge automatically.
7860d6e
to
225f520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex for the 1740k job was wrong, it was expecting Zebra to sync to 1740k, but our cached state is now after 1740k.
This makes the update sync workflows run their whole Zebra sync in that job, then fail with a GitHub timeout.
Instead, we want to finish that job when we reach 1740k or later.
I merged this manually, because:
|
Motivation
Currently Zebra CI is failing due to multiple timeouts.
Close #4910
Solution
Increase the full sync timeout from 16 hours to 20 hours.
Increase the update sync timeout from 1-3 hours to 11 hours.
Review
Anyone can review, if the CI pass i think we should merge this fast as it is blocking all the other PRs.
Reviewer Checklist
Follow Up Work
Update the checkpoints.